From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uwena-0005AJ-Ai for qemu-devel@nongnu.org; Tue, 09 Jul 2013 16:46:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwenZ-0003vN-9W for qemu-devel@nongnu.org; Tue, 09 Jul 2013 16:46:10 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:38087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwenZ-0003ur-23 for qemu-devel@nongnu.org; Tue, 09 Jul 2013 16:46:09 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 9 Jul 2013 14:45:47 -0600 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 742E56E803F for ; Tue, 9 Jul 2013 16:45:40 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r69Kjic6337514 for ; Tue, 9 Jul 2013 16:45:45 -0400 Received: from d01av05.pok.ibm.com (loopback [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r69KjilX005700 for ; Tue, 9 Jul 2013 16:45:44 -0400 From: Anthony Liguori In-Reply-To: <51DC5DEA.4060901@msgid.tls.msk.ru> References: <1371645291-3178-1-git-send-email-mjt@msgid.tls.msk.ru> <874nc337gq.fsf@codemonkey.ws> <51DC5DEA.4060901@msgid.tls.msk.ru> Date: Tue, 09 Jul 2013 15:45:42 -0500 Message-ID: <87li5fsbrd.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-devel@nongnu.org Michael Tokarev writes: > 09.07.2013 22:37, Anthony Liguori wrote: >> Michael Tokarev writes: >> >>> It looks like initially there was -nographic option to turn >>> off display, now there's another option of the same sort, >>> -display none. But code in other places of qemu checks for >>> DT_NOGRAPHIC and does not work well with -display none. >>> Make DT_NOGRAPHIC an internal version which selects DT_NONE, >>> and check for that in all other places where previously we >>> checked for DT_NOGRAPHIC. > [] >> Breaks make check: >> >> main-loop: WARNING: I/O thread spun for 1000 iterations >> ** >> ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic: assertion failed (qfw_cfg_get_u16(fw_cfg, FW_CFG_NOGRAPHIC) == 0): (1 == 0) >> GTester: last random seed: R02S25031265f05e4d41efcf758c9ef6043b > > Sure, because the test is bogus. No, it's a guest ABI. You cannot change the guest ABI. -display none != -nographic. nographic gives you -display none plus a stdio serial port (with muxing magic). -display none should not imply stdio serial port. The vc goes to a dummy display. That's a major semantic difference. Regards, Anthony Liguori > Should I remove this bogus test? > > Thanks, > > /mjt