From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40437)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UXy6E-0005y4-1M
	for qemu-devel@nongnu.org; Thu, 02 May 2013 14:19:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UXy6C-0000B8-R2
	for qemu-devel@nongnu.org; Thu, 02 May 2013 14:19:21 -0400
Received: from mail-ve0-x22f.google.com ([2607:f8b0:400c:c01::22f]:49246)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1UXy6C-0000B3-NK
	for qemu-devel@nongnu.org; Thu, 02 May 2013 14:19:20 -0400
Received: by mail-ve0-f175.google.com with SMTP id m1so799779ves.20
	for <qemu-devel@nongnu.org>; Thu, 02 May 2013 11:19:20 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <51829B71.60306@redhat.com>
References: <20130502135143.GA1171@redhat.com> <5182868D.3090200@redhat.com>
	<CAFEAcA_3s7ddz1uPPEja+151+0ARi24Q5SjftZOY=a=pAhggZg@mail.gmail.com>
	<877gjhv0og.fsf@codemonkey.ws>
	<20130502160626.GA14776@redhat.com> <51829B71.60306@redhat.com>
Date: Thu, 02 May 2013 13:19:11 -0500
Message-ID: <87li7xp7mo.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH
	08/29] cpu: Add qemu_for_each_cpu())
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> writes:

> Il 02/05/2013 18:06, Michael S. Tsirkin ha scritto:
>> On Thu, May 02, 2013 at 10:52:47AM -0500, Anthony Liguori wrote:
>>> Peter Maydell <peter.maydell@linaro.org> writes:
>>>
>>>> On 2 May 2013 16:30, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>>>> /me changes his scripts...
>>>>>
>>>>> -s/PATCH/PULL/ if (/PATCH 0+\\//);
>>>>> +s/PATCH/PULL/ if (/^Subject:/);
>>>>>
>>>>> Yes, Perl...
>>>>
>>>> Heh, I use sed for this bit:
>>>> sed -i -e 's/^Subject: \[PULL\(.*\)].*/Subject: [PULL\1]
>>>> '"$BRANCHPFX"' queue/;/^$/q' "$COVERLETTER"
>>>
>>> You can also just do git format-patch --subject-prefix=PULL and avoid
>>> any fixups...
>
> I still want to avoid any mistakes in case I override the subject prefix
> (e.g. to include 1.5)... Keeping the substitution is cheap and a nice
> safety net.
>
>> Don't forget -M please, especially if you are Paolo :)
>
> Or
>
> [diff]
>         renames = true
>         renamelimit = 2000

BTW, this is all great stuff to put in a SubmitAPullRequest page on the
wiki.  I don't send pull requests so I don't have a script to do this,
but I'd encourage those that do to share their scripts on the wiki.

Regards,

Anthony Liguori

>
> Paolo