From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38521)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TGdHn-0006gm-BG
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 18:07:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TGdHm-0004jU-B5
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 18:07:23 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:56320)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TGdHm-0004jP-4h
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 18:07:22 -0400
Received: by obbta14 with SMTP id ta14so6698985obb.4
	for <qemu-devel@nongnu.org>; Tue, 25 Sep 2012 15:07:21 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <1348577763-12920-14-git-send-email-pbonzini@redhat.com>
References: <1348577763-12920-1-git-send-email-pbonzini@redhat.com>
	<1348577763-12920-14-git-send-email-pbonzini@redhat.com>
Date: Tue, 25 Sep 2012 17:07:18 -0500
Message-ID: <87lifxn4dl.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 13/17] aio: call aio_notify after setting
	I/O handlers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> writes:

> In the current code, this is done by qemu_set_fd_handler2, which is
> called by qemu_aio_set_fd_handler.  We need to keep the same behavior
> even after removing the call to qemu_set_fd_handler2.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori


> ---
>  aio-posix.c | 2 ++
>  aio-win32.c | 2 ++
>  2 file modificati, 4 inserzioni(+)
>
> diff --git a/aio-posix.c b/aio-posix.c
> index e29ece9..41f638f 100644
> --- a/aio-posix.c
> +++ b/aio-posix.c
> @@ -90,6 +90,8 @@ void aio_set_fd_handler(AioContext *ctx,
>          node->pfd.events |= (io_read ? G_IO_IN | G_IO_HUP : 0);
>          node->pfd.events |= (io_write ? G_IO_OUT : 0);
>      }
> +
> +    aio_notify(ctx);
>  }
>  
>  void aio_set_event_notifier(AioContext *ctx,
> diff --git a/aio-win32.c b/aio-win32.c
> index 5057371..78faf69 100644
> --- a/aio-win32.c
> +++ b/aio-win32.c
> @@ -75,6 +75,8 @@ void aio_set_event_notifier(AioContext *ctx,
>          node->io_notify = io_notify;
>          node->io_flush = io_flush;
>      }
> +
> +    aio_notify(ctx);
>  }
>  
>  bool aio_pending(AioContext *ctx)
> -- 
> 1.7.12