From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE5BP-0007Qe-JW for qemu-devel@nongnu.org; Tue, 18 Sep 2012 17:18:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TE5BO-0006eL-2R for qemu-devel@nongnu.org; Tue, 18 Sep 2012 17:18:15 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:62175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE5BN-0006di-TF for qemu-devel@nongnu.org; Tue, 18 Sep 2012 17:18:13 -0400 Received: by oagn12 with SMTP id n12so337707oag.4 for ; Tue, 18 Sep 2012 14:18:13 -0700 (PDT) From: Anthony Liguori In-Reply-To: <50573283.3080206@redhat.com> References: <5054AC57.205@web.de> <5056E876.9010400@redhat.com> <5056EAF2.60205@web.de> <50573283.3080206@redhat.com> Date: Tue, 18 Sep 2012 16:18:09 -0500 Message-ID: <87lig76ne6.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede , Jan Kiszka Cc: qemu-devel , Gerd Hoffmann Hans de Goede writes: > Hi, > > On 09/17/2012 11:18 AM, Jan Kiszka wrote: >> On 2012-09-17 11:08, Hans de Goede wrote: > > > >>> Although not pretty I'm ok with this, since I actually want to add >>> similar code to allow usb-3 (superspeed) devices like a usb-3 usb-stick >>> to work with ehci or uhci controllers :) >> >> Great, that would have been my next question, but I don't have hardware >> for that around yet. > > I do have hardware for that around, so once you've respun your patch to > address the issues discussed, then that will give me a nice basis to > add usb-3 usb-stick to ehci-controller redirection :) > >> BTW, I'm facing several incompatibilities with passed-through CDC/ACM >> devices (e.g. a Galaxy S2), independent of my patch. Both host-linux and >> redir doesn't allow to use them properly but show different symptoms. >> Need to analyze and report once time permits. > > Hmm, there is (was) one know issues with these devices, which has been fixed > in usbredir, so first of all make sure that the usbredir on your spice-client > / usbredirserver, has this patch: > http://cgit.freedesktop.org/spice/usbredir/commit/?id=7783d3db61083bbf7f61b1ea8608c666b4c6a1dd > > If that does not work, add the debug parameter to the usb-redir device, set it > to 4, collect logs of trying to redirect the device and send me the logs > please, ie: > -device usb-redir,chardev=usbredirchardev1,id=usbredirdev1,debug=4 > > Also be aware that usb-redir relies on chardev flowcontrol working, > which it does not upstream! See for example here for the chardev flow > control patch set which RHEL / Fedora carry: > http://cgit.freedesktop.org/~jwrdegoede/qemu/log/?h=qemu-kvm-1.2-usbredir&ofs=50 Those patches are garbage. Are you saying that usb-redir doesn't work in qemu.git? So why are we even carrying it? Regards, Anthony Liguori > > And then the first 13 patches after: "Merge tag 'v1.2.0'" > > Oh, and also, if you're running qemu git master, make sure you've: > http://cgit.freedesktop.org/~jwrdegoede/qemu/commit/?id=81e34f5973d8d6a1ef998a50c4a4bf66abb3b56b > > Regards, > > Hans