From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzqOf-0003y9-4L for qemu-devel@nongnu.org; Fri, 10 Aug 2012 10:41:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SzqOd-0002NY-Nd for qemu-devel@nongnu.org; Fri, 10 Aug 2012 10:41:05 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:38988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SzqOd-0002N7-JZ for qemu-devel@nongnu.org; Fri, 10 Aug 2012 10:41:03 -0400 Received: from /spool/local by e5.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 10 Aug 2012 10:41:03 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id B608B38C8042 for ; Fri, 10 Aug 2012 10:40:58 -0400 (EDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7AEevpJ149226 for ; Fri, 10 Aug 2012 10:40:58 -0400 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7AEepaR010072 for ; Fri, 10 Aug 2012 08:40:52 -0600 From: Anthony Liguori In-Reply-To: <20120727130650.3a550bb1@doriath.home> References: <1343396239-19272-1-git-send-email-aliguori@us.ibm.com> <1343396239-19272-3-git-send-email-aliguori@us.ibm.com> <20120727130650.3a550bb1@doriath.home> Date: Fri, 10 Aug 2012 09:40:38 -0500 Message-ID: <87lihm6c9l.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 2/7] qapi: mark QOM commands stable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Peter Maydell , libvir-list@redhat.com, qemu-devel@nongnu.org, Markus Armbruster , Alexander Graf , Eric Blake Luiz Capitulino writes: > On Fri, 27 Jul 2012 08:37:14 -0500 > Anthony Liguori wrote: > >> We've had a cycle to tweak. It is time to commit to supporting them. > > qmp_qom_get() and qpm_qom_set() still use the legacy monitor interface, can't > we convert it to the qapi? qapi doesn't have a concept of type passthrough yet. If it was added, it could be converted. Regards, Anthony Liguori > >> >> Signed-off-by: Anthony Liguori >> --- >> qapi-schema.json | 19 ++++--------------- >> 1 files changed, 4 insertions(+), 15 deletions(-) >> >> diff --git a/qapi-schema.json b/qapi-schema.json >> index 015a84a..28e9914 100644 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -1360,9 +1360,7 @@ >> # 4) A link type in the form 'link' where subtype is a qdev >> # device type name. Link properties form the device model graph. >> # >> -# Since: 1.1 >> -# >> -# Notes: This type is experimental. Its syntax may change in future releases. >> +# Since: 1.2 >> ## >> { 'type': 'ObjectPropertyInfo', >> 'data': { 'name': 'str', 'type': 'str' } } >> @@ -1379,10 +1377,7 @@ >> # Returns: a list of @ObjectPropertyInfo that describe the properties of the >> # object. >> # >> -# Since: 1.1 >> -# >> -# Notes: This command is experimental. It's syntax may change in future >> -# releases. >> +# Since: 1.2 >> ## >> { 'command': 'qom-list', >> 'data': { 'path': 'str' }, >> @@ -1418,9 +1413,7 @@ >> # returns as #str pathnames. All integer property types (u8, u16, etc) >> # are returned as #int. >> # >> -# Since: 1.1 >> -# >> -# Notes: This command is experimental and may change syntax in future releases. >> +# Since: 1.2 >> ## >> { 'command': 'qom-get', >> 'data': { 'path': 'str', 'property': 'str' }, >> @@ -1439,9 +1432,7 @@ >> # @value: a value who's type is appropriate for the property type. See @qom-get >> # for a description of type mapping. >> # >> -# Since: 1.1 >> -# >> -# Notes: This command is experimental and may change syntax in future releases. >> +# Since: 1.2 >> ## >> { 'command': 'qom-set', >> 'data': { 'path': 'str', 'property': 'str', 'value': 'visitor' }, >> @@ -1719,8 +1710,6 @@ >> # Returns: a list of @ObjectTypeInfo or an empty list if no results are found >> # >> # Since: 1.1 >> -# >> -# Notes: This command is experimental and may change syntax in future releases. >> ## >> { 'command': 'qom-list-types', >> 'data': { '*implements': 'str', '*abstract': 'bool' },