From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Meador Inge <meadori@codesourcery.com>, qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: Re: [Qemu-devel] [PATCH v1 0/1] Allow the building of VirtFS to be disabled
Date: Wed, 08 Feb 2012 13:45:15 +0530 [thread overview]
Message-ID: <87liodivvw.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1328647446-5452-1-git-send-email-meadori@codesourcery.com>
On Tue, 7 Feb 2012 14:44:05 -0600, Meador Inge <meadori@codesourcery.com> wrote:
> There have been reports [1, 2] where folks have had issues building
> VirtFS and the virtio backend on older systems. I personally saw
> problems due to the use of features (struct statfs f_frsize field,
> fdopendir, O_NOATIME) in this code that are not available on much older
> Linux systems. Given, the system I ran into this on is ancient (RH8 sysroot),
> but I still need to build QEMU on it nonetheless.
>
> This patch adds a new configure option for disabling the building of
> VirtFS all together. Tested by building with and without --disable-virtfs
> on older (RH8 sysroot) and newer systems (x64 Fedora 16).
>
> [1] http://lists.nongnu.org/archive/html/qemu-devel/2011-12/msg00171.html
> [2] http://lists.nongnu.org/archive/html/qemu-devel/2012-02/msg00404.html
>
> Meador Inge (1):
> ./configure: add option for disabling VirtFS
>
> Makefile | 4 ++++
> configure | 16 +++++++++++++---
> 2 files changed, 17 insertions(+), 3 deletions(-)
I like the patch because it help to get qemu build on platforms where
the build failures are only due to virtfs. VirtFS do depend on some of
the recent linux APIs, so sometime we do break build on old Linux
distros.
Anthony any objection here ?
-aneesh
next prev parent reply other threads:[~2012-02-08 8:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 20:44 [Qemu-devel] [PATCH v1 0/1] Allow the building of VirtFS to be disabled Meador Inge
2012-02-07 20:44 ` [Qemu-devel] [PATCH v1 1/1] ./configure: add option for disabling VirtFS Meador Inge
2012-02-09 22:39 ` Peter Maydell
2012-02-10 0:49 ` Meador Inge
2012-02-08 8:15 ` Aneesh Kumar K.V [this message]
2012-02-08 10:14 ` [Qemu-devel] [PATCH v1 0/1] Allow the building of VirtFS to be disabled Daniel P. Berrange
2012-02-09 22:25 ` Meador Inge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87liodivvw.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=meadori@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).