From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41825 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PzPkV-00015i-H3 for qemu-devel@nongnu.org; Tue, 15 Mar 2011 04:37:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PzPkU-00036i-9a for qemu-devel@nongnu.org; Tue, 15 Mar 2011 04:37:03 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:59419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PzPkT-00036Q-O7 for qemu-devel@nongnu.org; Tue, 15 Mar 2011 04:37:02 -0400 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [202.81.31.247]) by e23smtp04.au.ibm.com (8.14.4/8.13.1) with ESMTP id p2F8VQqa000521 for ; Tue, 15 Mar 2011 19:31:26 +1100 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p2F8b0e91732664 for ; Tue, 15 Mar 2011 19:37:00 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p2F8axZ6015826 for ; Tue, 15 Mar 2011 19:37:00 +1100 From: "Aneesh Kumar K. V" Subject: Re: [Qemu-devel] [PATCH -V3 7/8] hw/9pfs: Add new virtfs option cache=none to skip host page cache In-Reply-To: References: <1299347533-17047-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1299347533-17047-7-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <87y64iq1tz.fsf@linux.vnet.ibm.com> Date: Tue, 15 Mar 2011 14:06:55 +0530 Message-ID: <87lj0gwziw.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On Sun, 13 Mar 2011 20:57:12 +0000, Stefan Hajnoczi wr= ote: > On Sun, Mar 13, 2011 at 7:04 PM, Aneesh Kumar K. V > wrote: > > On Sun, 13 Mar 2011 17:23:50 +0000, Stefan Hajnoczi wrote: > >> On Sat, Mar 5, 2011 at 5:52 PM, Aneesh Kumar K.V > >> wrote: > >> > cache=3Dnone implies the file are opened in the host with O_SYNC ope= n flag > >> > >> O_SYNC does not bypass the host page cache. =C2=A0It ensures that writ= es > >> only complete once data has been written to the disk. > >> > >> O_DIRECT is a hint to bypass the host page cache when possible. > >> > >> A boolean on|off option would be nicer than an option that takes the > >> special string "none". =C2=A0For example, direct=3Don|off. =C2=A0It al= so makes the > >> code nicer by using bools instead of strdup strings that get leaked. > >> > > > > What i wanted is the O_SYNC behavior. Well the comment should be update= d. I > > want to make sure that we don't have dirty data in host page cache after > > a write. It is always good to make read hit the page cache >=20 > I have sent a patch to clean up the -virtfs option parsing, you are > CCed. I think it will make it easier to add a new sync=3Don|off option. Absolutely. So what i will do is i will carry the patch in the series and later will drop the same once your changes get pushed upstream.=20 -aneesh