From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Gustavo Romero <gustavo.romero@linaro.org>,
qemu-devel@nongnu.org, pierrick.bouvier@linaro.org,
manos.pitsidianakis@linaro.org, qemu-arm@nongnu.org
Subject: Re: [PATCH v2] tests/tcg: Fix run for tests with specific plugin
Date: Mon, 04 Aug 2025 10:48:46 +0100 [thread overview]
Message-ID: <87ms8f76yp.fsf@draig.linaro.org> (raw)
In-Reply-To: <CAFEAcA-6wr+frdc4idVs45POcPVG54FFTbtqPu3x9Jzfa-gwow@mail.gmail.com> (Peter Maydell's message of "Fri, 1 Aug 2025 14:29:33 +0100")
Peter Maydell <peter.maydell@linaro.org> writes:
> On Fri, 1 Aug 2025 at 01:18, Gustavo Romero <gustavo.romero@linaro.org> wrote:
>>
>> Commit 25aaf0cb7f (“tests/tcg: reduce the number of plugin test
>> combinations”) added support for running tests with specific plugins
>> passed via the EXTRA_RUNS variable.
>>
>> However, due to the optimization, the rules generated as a shuffled
>> combination of tests and plugins might not cover the rules required to
>> run the tests with a specific plugin passed via EXTRA_RUNS.
>>
>> This commit fixes it by correctly generating the rules for the tests
>> that require a specific plugin to run, which are now passed via the
>> EXTRA_RUNS_WITH_PLUGIN instead of via the EXTRA_RUNS variable.
>>
>> The fix essentially excludes the tests passed via EXTRA_RUNS_WITH_PLUGIN
>> from the rules created by the shuffled combination of tests and plugins,
>> to avoid running the tests twice, and generates the rules for the
>> test/plugin combinations listed in the EXTRA_RUNS_WITH_PLUGIN variable.
>>
>
> Since Alex is away and I'm doing a target-arm pullreq for rc2
> anyway, I'll take this via target-arm.next.
Are you sending that today? Otherwise I'm happy to pull it now I'm back.
>
> thanks
> -- PMM
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2025-08-04 9:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 0:13 [PATCH v2] tests/tcg: Fix run for tests with specific plugin Gustavo Romero
2025-08-01 0:44 ` Pierrick Bouvier
2025-08-01 13:29 ` Peter Maydell
2025-08-04 9:48 ` Alex Bennée [this message]
2025-08-04 9:56 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ms8f76yp.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=gustavo.romero@linaro.org \
--cc=manos.pitsidianakis@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).