From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 578E7C41513 for ; Wed, 12 Jun 2024 14:28:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHOws-0000I8-T5; Wed, 12 Jun 2024 10:27:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHOws-0000Bz-04 for qemu-devel@nongnu.org; Wed, 12 Jun 2024 10:27:38 -0400 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sHOwp-0000Go-KC for qemu-devel@nongnu.org; Wed, 12 Jun 2024 10:27:37 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2D63E34507; Wed, 12 Jun 2024 14:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718202452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=euzO7BKKPaNSkrdgQBHeImIa7/2qybrOxx0gqRMVxLU=; b=Poywe6nn89jkpWKBo3cdDxG2wLWoxPJxqNxIKfpOMm/PGVPUc1RUo+sr1Qhh9urBmVtUkP cLY7ONI3oM9IORC7LVWnzPeVHqIaiS+38TeLwtboV9X150knCjaCHgARrmjW6WU6KDQNPY 1HNGN1gIpwzUShqp4DQ/VBq1DQjrcOM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718202452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=euzO7BKKPaNSkrdgQBHeImIa7/2qybrOxx0gqRMVxLU=; b=mOLipUIeMuRILzeCafZJH6STX3O+3k18ykDNhu5FOszgJA2labhjXA+XEmPcNEJgrY3Qir Kwox41uNJxi1fkAg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718202452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=euzO7BKKPaNSkrdgQBHeImIa7/2qybrOxx0gqRMVxLU=; b=Poywe6nn89jkpWKBo3cdDxG2wLWoxPJxqNxIKfpOMm/PGVPUc1RUo+sr1Qhh9urBmVtUkP cLY7ONI3oM9IORC7LVWnzPeVHqIaiS+38TeLwtboV9X150knCjaCHgARrmjW6WU6KDQNPY 1HNGN1gIpwzUShqp4DQ/VBq1DQjrcOM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718202452; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=euzO7BKKPaNSkrdgQBHeImIa7/2qybrOxx0gqRMVxLU=; b=mOLipUIeMuRILzeCafZJH6STX3O+3k18ykDNhu5FOszgJA2labhjXA+XEmPcNEJgrY3Qir Kwox41uNJxi1fkAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A37761372E; Wed, 12 Jun 2024 14:27:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ML6hGlOwaWZrSwAAD6G6ig (envelope-from ); Wed, 12 Jun 2024 14:27:31 +0000 From: Fabiano Rosas To: Yuan Liu , peterx@redhat.com, pbonzini@redhat.com, marcandre.lureau@redhat.com, berrange@redhat.com, thuth@redhat.com, philmd@linaro.org Cc: qemu-devel@nongnu.org, yuan1.liu@intel.com, nanhai.zou@intel.com, shameerali.kolothum.thodi@huawei.com Subject: Re: [PATCH v8 4/7] migration/multifd: add qpl compression method In-Reply-To: <20240610102110.900410-5-yuan1.liu@intel.com> References: <20240610102110.900410-1-yuan1.liu@intel.com> <20240610102110.900410-5-yuan1.liu@intel.com> Date: Wed, 12 Jun 2024 11:27:29 -0300 Message-ID: <87msnqck32.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Spamd-Result: default: False [-4.29 / 50.00]; BAYES_HAM(-2.99)[99.97%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[11]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[intel.com:email, suse.de:email, imap1.dmz-prg2.suse.org:helo] Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Yuan Liu writes: > add the Query Processing Library (QPL) compression method > > Introduce the qpl as a new multifd migration compression method, it can > use In-Memory Analytics Accelerator(IAA) to accelerate compression and > decompression, which can not only reduce network bandwidth requirement > but also reduce host compression and decompression CPU overhead. > > How to enable qpl compression during migration: > migrate_set_parameter multifd-compression qpl > > There is no qpl compression level parameter added since it only supports > level one, users do not need to specify the qpl compression level. > > Signed-off-by: Yuan Liu > Reviewed-by: Nanhai Zou > Reviewed-by: Peter Xu > Reviewed-by: Fabiano Rosas I don't think I ever reviewed this patch. Please drop this when you resubmit.