From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 608A9C25B10 for ; Mon, 13 May 2024 15:00:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6X9t-0003KU-TJ; Mon, 13 May 2024 11:00:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6X9s-0003K8-2H for qemu-devel@nongnu.org; Mon, 13 May 2024 11:00:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6X9q-0008CX-9b for qemu-devel@nongnu.org; Mon, 13 May 2024 11:00:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715612404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dmQSa6D0Vthq9mhhRE9MfwOiMQ0rqL+V/Og/ZvkFXFw=; b=hk2CZ+D7/Fz+Pa5AXcA6XKbdPnUZgotBe+ZH9p00KXy8kQp7+wGCoaXIDXinBW6DRyowzy bi8Wkawroqu8tH2F2uU/ffiD80vK+185yRPkLHFCEETAriuLjoq+s3DshmFesgn9e5MMpH WcPdiAoom2VvBwXPD50s05A+GvVWMOE= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-lkxCduujOe6M17DZhRrn1A-1; Mon, 13 May 2024 10:48:23 -0400 X-MC-Unique: lkxCduujOe6M17DZhRrn1A-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3E82338135EA; Mon, 13 May 2024 14:48:23 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1D735400056; Mon, 13 May 2024 14:48:23 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3898421E66E5; Mon, 13 May 2024 16:48:22 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, fam@euphon.net, kwolf@redhat.com, hreitz@redhat.com, marcandre.lureau@redhat.com, peterx@redhat.com, farosas@suse.de, pbonzini@redhat.com, richard.henderson@linaro.org, qemu-block@nongnu.org Subject: Re: [PATCH 2/6] dump/win_dump: Improve error messages on write error In-Reply-To: <5a74f1af-6068-41b1-b875-6be060369abe@linaro.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Mon, 13 May 2024 16:22:54 +0200") References: <20240513141703.549874-1-armbru@redhat.com> <20240513141703.549874-3-armbru@redhat.com> <5a74f1af-6068-41b1-b875-6be060369abe@linaro.org> Date: Mon, 13 May 2024 16:48:22 +0200 Message-ID: <87msot6a4p.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.974, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Philippe Mathieu-Daud=C3=A9 writes: > On 13/5/24 16:16, Markus Armbruster wrote: >> create_win_dump() and write_run report qemu_write_full() failure to >> their callers as >> An IO error has occurred >> The errno set by qemu_write_full() is lost. >> Improve this to >> win-dump: failed to write header: >> and >> win-dump: failed to save memory: >> This matches how dump.c reports similar errors. >> Signed-off-by: Markus Armbruster >> --- >> dump/win_dump.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> diff --git a/dump/win_dump.c b/dump/win_dump.c >> index b7bfaff379..0e4fe692ce 100644 >> --- a/dump/win_dump.c >> +++ b/dump/win_dump.c >> @@ -12,7 +12,6 @@ >> #include "sysemu/dump.h" >> #include "qapi/error.h" >> #include "qemu/error-report.h" >> -#include "qapi/qmp/qerror.h" >> #include "exec/cpu-defs.h" >> #include "hw/core/cpu.h" >> #include "qemu/win_dump_defs.h" >> @@ -52,6 +51,7 @@ static size_t write_run(uint64_t base_page, uint64_t p= age_count, >> uint64_t addr =3D base_page << TARGET_PAGE_BITS; >> uint64_t size =3D page_count << TARGET_PAGE_BITS; >> uint64_t len, l; >> + int eno; >> size_t total =3D 0; >> while (size) { >> @@ -65,9 +65,10 @@ static size_t write_run(uint64_t base_page, uint64_t = page_count, >> } >> l =3D qemu_write_full(fd, buf, len); >> + eno =3D errno; > > Hmm this show the qemu_write_full() API isn't ideal. > Maybe we could pass &l as argument and return errno. > There are only 20 calls. qemu_write_full() is a drop-in replacement for write(). >> cpu_physical_memory_unmap(buf, addr, false, len); >> if (l !=3D len) { >> - error_setg(errp, QERR_IO_ERROR); >> + error_setg_errno(errp, eno, "win-dump: failed to save memor= y"); >> return 0; >> } >> @@ -459,7 +460,7 @@ void create_win_dump(DumpState *s, Error **errp) >> s->written_size =3D qemu_write_full(s->fd, h, hdr_size); >> if (s->written_size !=3D hdr_size) { >> - error_setg(errp, QERR_IO_ERROR); >> + error_setg_errno(errp, errno, "win-dump: failed to write header= "); >> goto out_restore; >> } >>=20=20=20