From: Fabiano Rosas <farosas@suse.de>
To: Markus Armbruster <armbru@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
devel@lists.libvirt.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Eric Blake" <eblake@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>
Subject: Re: [PATCH 3/6] migration: Remove 'blk/-b' option from migrate commands
Date: Fri, 26 Apr 2024 11:19:31 -0300 [thread overview]
Message-ID: <87mspg6wb0.fsf@suse.de> (raw)
In-Reply-To: <87o79wrzgx.fsf@pond.sub.org>
Markus Armbruster <armbru@redhat.com> writes:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Fabiano Rosas <farosas@suse.de> writes:
>>
>>> The block migration is considered obsolete and has been deprecated in
>>> 8.2. Remove the migrate command option that enables it. This only
>>> affects the QMP and HMP commands, the feature can still be accessed by
>>> setting the migration 'block' capability. The whole feature will be
>>> removed in a future patch.
>>>
>>> Deprecation commit 8846b5bfca ("migration: migrate 'blk' command
>>> option is deprecated.").
>>>
>>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>>
>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
> I think you missed the update to hmp-commands.hx. I almost missed it,
> too :)
Nice catch, it was bound to happen. There's approximately 9000 instances
of 'blk' in this project.
next prev parent reply other threads:[~2024-04-26 14:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 15:09 [PATCH 0/6] migration removals & deprecations Fabiano Rosas
2024-04-25 15:09 ` [PATCH 1/6] migration: Remove 'skipped' field from MigrationStats Fabiano Rosas
2024-04-26 5:26 ` Markus Armbruster
2024-04-25 15:09 ` [PATCH 2/6] migration: Remove 'inc' option from migrate command Fabiano Rosas
2024-04-26 13:25 ` Markus Armbruster
2024-04-26 14:07 ` Markus Armbruster
2024-04-25 15:09 ` [PATCH 3/6] migration: Remove 'blk/-b' option from migrate commands Fabiano Rosas
2024-04-26 13:26 ` Markus Armbruster
2024-04-26 14:05 ` Markus Armbruster
2024-04-26 14:19 ` Fabiano Rosas [this message]
2024-04-25 15:09 ` [PATCH 4/6] migration: Remove block migration Fabiano Rosas
2024-04-26 14:15 ` Markus Armbruster
2024-04-25 15:09 ` [PATCH 5/6] migration: Remove non-multifd compression Fabiano Rosas
2024-04-26 14:27 ` Markus Armbruster
2024-04-25 15:09 ` [PATCH 6/6] migration: Deprecate fd: for file migration Fabiano Rosas
2024-04-26 6:02 ` [PATCH 0/6] migration removals & deprecations Markus Armbruster
2024-04-26 12:51 ` Fabiano Rosas
2024-04-26 13:08 ` Markus Armbruster
2024-04-26 13:15 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mspg6wb0.fsf@suse.de \
--to=farosas@suse.de \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=devel@lists.libvirt.org \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).