From: "Alex Bennée" <alex.bennee@linaro.org>
To: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org,
qemu-block@nongnu.org, peter.maydell@linaro.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v3 2/6] hw/arm/z2: convert DPRINTF to trace events and guest errors
Date: Tue, 30 Jan 2024 10:02:20 +0000 [thread overview]
Message-ID: <87mssnqgur.fsf@draig.linaro.org> (raw)
In-Reply-To: <799c5141c5751cf2341e1d095349612e046424a8.1706544115.git.manos.pitsidianakis@linaro.org> (Manos Pitsidianakis's message of "Mon, 29 Jan 2024 18:09:37 +0200")
Manos Pitsidianakis <manos.pitsidianakis@linaro.org> writes:
> Tracing DPRINTFs to stderr might not be desired. A developer that relies
> on trace events should be able to opt-in to each trace event and rely on
> QEMU's log redirection, instead of stderr by default.
>
> This commit converts DPRINTFs in this file that are used for tracing
> into trace events. DPRINTFs that report guest errors are logged with
> LOG_GUEST_ERROR.
>
> Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2024-01-30 10:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 16:09 [PATCH v3 0/6] hw/{arm,xen} convert printfs to trace/reports Manos Pitsidianakis
2024-01-29 16:09 ` [PATCH v3 1/6] hw/arm/strongarm.c: convert DPRINTF to trace events and guest errors Manos Pitsidianakis
2024-01-29 19:49 ` Alex Bennée
2024-01-29 16:09 ` [PATCH v3 2/6] hw/arm/z2: " Manos Pitsidianakis
2024-01-30 10:02 ` Alex Bennée [this message]
2024-01-29 16:09 ` [PATCH v3 3/6] hw/arm/xen_arm.c: convert DPRINTF to trace events and error/warn reports Manos Pitsidianakis
2024-01-30 10:03 ` Alex Bennée
2024-01-29 16:09 ` [PATCH v3 4/6] hw/xen/xen-mapcache.c: convert DPRINTF to tracepoints Manos Pitsidianakis
2024-01-30 10:05 ` Alex Bennée
2024-01-29 16:09 ` [PATCH v3 5/6] hw/xen/xen-hvm-common.c: " Manos Pitsidianakis
2024-01-30 10:07 ` Alex Bennée
2024-01-29 16:09 ` [PATCH v3 6/6] hw/xen: convert stderr prints to error/warn reports Manos Pitsidianakis
2024-01-30 10:07 ` Alex Bennée
2024-02-01 15:32 ` [PATCH v3 0/6] hw/{arm,xen} convert printfs to trace/reports Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mssnqgur.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=manos.pitsidianakis@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).