From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09A2AC4725D for ; Fri, 19 Jan 2024 13:26:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQosk-0007p2-Mw; Fri, 19 Jan 2024 08:26:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQosj-0007is-73 for qemu-devel@nongnu.org; Fri, 19 Jan 2024 08:26:01 -0500 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQosh-00080T-LX for qemu-devel@nongnu.org; Fri, 19 Jan 2024 08:26:00 -0500 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3CF9A21EAD; Fri, 19 Jan 2024 13:25:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705670758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HHFmFUlfLfuI4rh7WqnUKB1dVFoaYv3P8CiB2fUfqF8=; b=ztRlhvf32qgiOOEhD2VOBN6BhQKecG3CodnOrPZLXDMbJtJIlcYzwmP3e4wjYZdq/HPHki VagYNReiGcEasJI30bfJlsyTIfTVOURyFoN+7E7yr6Av37FCkZWFWi9Sz7UApbv7k3klN7 e1uaAfBZkqAkrWBWZJ/NFE4E82SxcTY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705670758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HHFmFUlfLfuI4rh7WqnUKB1dVFoaYv3P8CiB2fUfqF8=; b=kftEGO2DNv7YvF7nw0N6fszOBMM6pzPmXtK60kx3NssOex0xOXrJVRNnzXs5eBZeUlr9rd i/K8ul8J+Fssn7Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705670758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HHFmFUlfLfuI4rh7WqnUKB1dVFoaYv3P8CiB2fUfqF8=; b=ztRlhvf32qgiOOEhD2VOBN6BhQKecG3CodnOrPZLXDMbJtJIlcYzwmP3e4wjYZdq/HPHki VagYNReiGcEasJI30bfJlsyTIfTVOURyFoN+7E7yr6Av37FCkZWFWi9Sz7UApbv7k3klN7 e1uaAfBZkqAkrWBWZJ/NFE4E82SxcTY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705670758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HHFmFUlfLfuI4rh7WqnUKB1dVFoaYv3P8CiB2fUfqF8=; b=kftEGO2DNv7YvF7nw0N6fszOBMM6pzPmXtK60kx3NssOex0xOXrJVRNnzXs5eBZeUlr9rd i/K8ul8J+Fssn7Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B99CA1388C; Fri, 19 Jan 2024 13:25:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rIK4H2V4qmUtHQAAD6G6ig (envelope-from ); Fri, 19 Jan 2024 13:25:57 +0000 From: Fabiano Rosas To: peterx@redhat.com, qemu-devel@nongnu.org Cc: Prasad Pandit , peterx@redhat.com, Bandan Das , Julia Suvorova Subject: Re: [PATCH 2/3] migration: Drop unnecessary check in ram's pending_exact() In-Reply-To: <20240117075848.139045-3-peterx@redhat.com> References: <20240117075848.139045-1-peterx@redhat.com> <20240117075848.139045-3-peterx@redhat.com> Date: Fri, 19 Jan 2024 10:25:55 -0300 Message-ID: <87mst1zc7w.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ztRlhvf3; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=kftEGO2D X-Spamd-Result: default: False [-2.30 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-1.99)[94.98%]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 3CF9A21EAD Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org peterx@redhat.com writes: > From: Peter Xu > > When the migration frameworks fetches the exact pending sizes, it means > this check: > > remaining_size < s->threshold_size > > Must have been done already, actually at migration_iteration_run(): > > if (must_precopy <= s->threshold_size) { > qemu_savevm_state_pending_exact(&must_precopy, &can_postcopy); > > That should be after one round of ram_state_pending_estimate(). It makes > the 2nd check meaningless and can be dropped. > > To say it in another way, when reaching ->state_pending_exact(), we > unconditionally sync dirty bits for precopy. > > Then we can drop migrate_get_current() there too. > > Signed-off-by: Peter Xu Reviewed-by: Fabiano Rosas