From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A748C25B67 for ; Thu, 26 Oct 2023 13:28:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qw0Ox-0007QA-5y; Thu, 26 Oct 2023 09:27:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qw0Ow-0007Pf-5G for qemu-devel@nongnu.org; Thu, 26 Oct 2023 09:27:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qw0Or-00005Z-4y for qemu-devel@nongnu.org; Thu, 26 Oct 2023 09:27:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698326868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ypEswjR1I3pikRd2okcZJx4sIOe8iWMAW8PsZlEAlPM=; b=e96Ca2rrh4I/79rOh8EG2uDFzBZjpN4/9FZtxqxYj7alitAsYBIpC04nx/7raRoEkBlM1x J1Fnj6DMfMl1chcm69bZAUiJAWjEnyj6BptWZRq4dUhy9t3I705f+m66kAN+/LZQlBGlcQ SLf9zx/taSGRmiZUCVWrtPwdNiPdfyA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-81-f0AsEZJBPoKAAgqbX6o7LQ-1; Thu, 26 Oct 2023 09:27:45 -0400 X-MC-Unique: f0AsEZJBPoKAAgqbX6o7LQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4293091856A; Thu, 26 Oct 2023 13:27:45 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.193.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 033602026D4C; Thu, 26 Oct 2023 13:27:44 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 17EDD21E6A1F; Thu, 26 Oct 2023 15:27:44 +0200 (CEST) From: Markus Armbruster To: Zhenzhong Duan Cc: qemu-devel@nongnu.org, alex.williamson@redhat.com, clg@redhat.com, jgg@nvidia.com, nicolinc@nvidia.com, joao.m.martins@oracle.com, eric.auger@redhat.com, peterx@redhat.com, jasowang@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com, yi.y.sun@intel.com, chao.p.peng@intel.com, Paolo Bonzini , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Eduardo Habkost , Eric Blake Subject: Re: [PATCH v3 24/37] backends/iommufd: Introduce the iommufd object References: <20231026103104.1686921-1-zhenzhong.duan@intel.com> <20231026103104.1686921-25-zhenzhong.duan@intel.com> Date: Thu, 26 Oct 2023 15:27:44 +0200 In-Reply-To: <20231026103104.1686921-25-zhenzhong.duan@intel.com> (Zhenzhong Duan's message of "Thu, 26 Oct 2023 18:30:51 +0800") Message-ID: <87msw5a4z3.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Zhenzhong Duan writes: > From: Eric Auger > > Introduce an iommufd object which allows the interaction > with the host /dev/iommu device. > > The /dev/iommu can have been already pre-opened outside of qemu, > in which case the fd can be passed directly along with the > iommufd object: > > This allows the iommufd object to be shared accross several > subsystems (VFIO, VDPA, ...). For example, libvirt would open > the /dev/iommu once. > > If no fd is passed along with the iommufd object, the /dev/iommu > is opened by the qemu code. > > The CONFIG_IOMMUFD option must be set to compile this new object. > > Suggested-by: Alex Williamson > Signed-off-by: Eric Auger > Signed-off-by: Yi Liu > Signed-off-by: Zhenzhong Duan > Signed-off-by: C=C3=A9dric Le Goater > --- > MAINTAINERS | 7 + > qapi/qom.json | 20 +++ > include/sysemu/iommufd.h | 46 +++++++ > backends/iommufd-stub.c | 59 +++++++++ > backends/iommufd.c | 268 +++++++++++++++++++++++++++++++++++++++ > backends/Kconfig | 4 + > backends/meson.build | 5 + > backends/trace-events | 12 ++ > qemu-options.hx | 13 ++ > 9 files changed, 434 insertions(+) > create mode 100644 include/sysemu/iommufd.h > create mode 100644 backends/iommufd-stub.c > create mode 100644 backends/iommufd.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index 7f9912baa0..7aa57ab16f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2109,6 +2109,13 @@ F: hw/vfio/ap.c > F: docs/system/s390x/vfio-ap.rst > L: qemu-s390x@nongnu.org >=20=20 > +iommufd > +M: Yi Liu > +M: Eric Auger > +S: Supported > +F: backends/iommufd.c > +F: include/sysemu/iommufd.h > + > vhost > M: Michael S. Tsirkin > S: Supported > diff --git a/qapi/qom.json b/qapi/qom.json > index c53ef978ff..ef0b50f107 100644 > --- a/qapi/qom.json > +++ b/qapi/qom.json > @@ -794,6 +794,22 @@ > { 'struct': 'VfioUserServerProperties', > 'data': { 'socket': 'SocketAddress', 'device': 'str' } } >=20=20 > +## > +# @IOMMUFDProperties: > +# > +# Properties for iommufd objects. > +# > +# @fd: file descriptor name previously passed via 'getfd' command, > +# which represents a pre-opened /dev/iommu. This allows the Two spaces between sentences for consistency, please. > +# iommufd object to be shared accross several subsystems > +# (VFIO, VDPA, ...) and file descriptor to be shared with Comma before "and file". Either "the file descriptor", or "file descriptors". > +# other process, e.g: DPDK. e.g. Alternatively "such as DPDK." > +# > +# Since: 8.2 > +## > +{ 'struct': 'IOMMUFDProperties', > + 'data': { '*fd': 'str' } } @fd is optional. How does the iommufd object behave when @fd is absent? > + > ## > # @RngProperties: > # > @@ -934,6 +950,8 @@ ## # @ObjectType: None of the enum members are documented. I'm not asking you to fix that now. # # Features: # # @unstable: Member @x-remote-object is experimental. # # Since: 6.0 ## { 'enum': 'ObjectType', 'data': [ [...] > 'input-barrier', > { 'name': 'input-linux', > 'if': 'CONFIG_LINUX' }, > + { 'name': 'iommufd', > + 'if': 'CONFIG_IOMMUFD' }, Should struct IOMMUFDProperties also have 'if': 'CONFIG_IOMMUFD'? > 'iothread', > 'main-loop', > { 'name': 'memory-backend-epc', > @@ -1003,6 +1021,8 @@ > 'input-barrier': 'InputBarrierProperties', > 'input-linux': { 'type': 'InputLinuxProperties', > 'if': 'CONFIG_LINUX' }, > + 'iommufd': { 'type': 'IOMMUFDProperties', > + 'if': 'CONFIG_IOMMUFD' }, > 'iothread': 'IothreadProperties', > 'main-loop': 'MainLoopProperties', > 'memory-backend-epc': { 'type': 'MemoryBackendEpcPropertie= s', [...]