* [PATCH] tests/qtest/migration-test: Disable the analyze-migration.py test on s390x
@ 2023-10-18 9:12 Thomas Huth
2023-10-18 10:01 ` Juan Quintela
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2023-10-18 9:12 UTC (permalink / raw)
To: Juan Quintela, qemu-devel, Peter Xu, Fabiano Rosas, Leonardo Bras
Cc: qemu-s390x
The analyze-migration.py script fails on s390x hosts:
Traceback (most recent call last):
File "scripts/analyze-migration.py", line 662, in <module>
dump.read(dump_memory = args.memory)
File "scripts/analyze-migration.py", line 596, in read
classdesc = self.section_classes[section_key]
KeyError: ('s390-storage_attributes', 0)
It obviously never has been adapted to s390x yet, so until this
has been done, disable this test on s390x.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/migration-test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index e1c110537b..241b409857 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -3034,7 +3034,9 @@ int main(int argc, char **argv)
qtest_add_func("/migration/bad_dest", test_baddest);
#ifndef _WIN32
- qtest_add_func("/migration/analyze-script", test_analyze_script);
+ if (!g_str_equal(arch, "s390x")) {
+ qtest_add_func("/migration/analyze-script", test_analyze_script);
+ }
#endif
qtest_add_func("/migration/precopy/unix/plain", test_precopy_unix_plain);
qtest_add_func("/migration/precopy/unix/xbzrle", test_precopy_unix_xbzrle);
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tests/qtest/migration-test: Disable the analyze-migration.py test on s390x
2023-10-18 9:12 [PATCH] tests/qtest/migration-test: Disable the analyze-migration.py test on s390x Thomas Huth
@ 2023-10-18 10:01 ` Juan Quintela
0 siblings, 0 replies; 2+ messages in thread
From: Juan Quintela @ 2023-10-18 10:01 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Peter Xu, Fabiano Rosas, Leonardo Bras, qemu-s390x
Thomas Huth <thuth@redhat.com> wrote:
> The analyze-migration.py script fails on s390x hosts:
>
> Traceback (most recent call last):
> File "scripts/analyze-migration.py", line 662, in <module>
> dump.read(dump_memory = args.memory)
> File "scripts/analyze-migration.py", line 596, in read
> classdesc = self.section_classes[section_key]
> KeyError: ('s390-storage_attributes', 0)
>
> It obviously never has been adapted to s390x yet, so until this
> has been done, disable this test on s390x.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-18 10:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-18 9:12 [PATCH] tests/qtest/migration-test: Disable the analyze-migration.py test on s390x Thomas Huth
2023-10-18 10:01 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).