From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F252FCE7A8C for ; Sat, 23 Sep 2023 07:14:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjwq8-0002yw-K2; Sat, 23 Sep 2023 03:14:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjwq4-0002xx-IP for qemu-devel@nongnu.org; Sat, 23 Sep 2023 03:14:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjwq2-0007dQ-81 for qemu-devel@nongnu.org; Sat, 23 Sep 2023 03:14:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695453237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5PuitPEavMpgxfNRjSKRyUWbURuUmzXU2EvZSbwb2oA=; b=Cj6VD1aM/cXNplqfNiVNrYNDdrbWS1tAs2bVQYYxyRJIKWtAYrAHGSAdDvL7vbPImwo1Fs mfAMgk1pbPKs30ClzB25YNSeoQ3Yggk85fg4l1msn/Efq1rh767Dn/M/RNynA/K40sADCP v/c9y/XzH2C9xiQSiPo5UhErhSh3wH4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-412-hu45Gv8APieRUwTsGtn12A-1; Sat, 23 Sep 2023 03:13:51 -0400 X-MC-Unique: hu45Gv8APieRUwTsGtn12A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4012285A5A8; Sat, 23 Sep 2023 07:13:51 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF4892156701; Sat, 23 Sep 2023 07:13:50 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id B8FCE21E6900; Sat, 23 Sep 2023 09:13:49 +0200 (CEST) From: Markus Armbruster To: =?utf-8?Q?C=C3=A9dric?= Le Goater Cc: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, qemu-devel@nongnu.org, Joel Stanley , Andrew Jeffery Subject: Re: [PATCH 0/4] aspeed: Clean up local variable shadowing References: <20230922155924.1172019-1-clg@kaod.org> <838837dc-0d95-1d6c-3cfc-e321c9c01a7d@kaod.org> Date: Sat, 23 Sep 2023 09:13:49 +0200 In-Reply-To: <838837dc-0d95-1d6c-3cfc-e321c9c01a7d@kaod.org> (=?utf-8?Q?=22C=C3=A9dric?= Le Goater"'s message of "Fri, 22 Sep 2023 21:00:37 +0200") Message-ID: <87msxdmkeq.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org C=C3=A9dric Le Goater writes: > On 9/22/23 20:20, Philippe Mathieu-Daud=C3=A9 wrote: >> On 22/9/23 17:59, C=C3=A9dric Le Goater wrote: >>> Hello, >>> >>> Here are cleanups for local variable shadowing warnings in aspeed model= s. >>> >>> Joel, Andrew, >>> >>> Could you please double check patch 4 ? >> Could Markus' MAKE_IDENTFIER() help there? > > ah ! you typed too fast and I also read too fast, as : > > MARKUS_IDENTIFIER() > > and I liked it :) LOL > but what is MAKE_IDENTIFIER ? really, please explain. Philippe is referring to [PATCH v3 7/7] qobject atomics osdep: Make a few macros more hygienic Message-ID: <20230921121312.1301864-8-armbru@redhat.com> which tweaks MAX() to permit nesting without shadowing. Your PATCH 4 may not be needed if you base on it. MAKE_IDENTIFIER() is a helper macro introduced in that patch. You can fetch the patch from https://repo.or.cz/qemu/armbru.git branch shadow-next, along with collected other shadowing patches. Questions?