From: Juan Quintela <quintela@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Jiang Jiacheng <jiangjiacheng@huawei.com>,
Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH v2 2/3] migration/multifd: Protect accesses to migration_threads
Date: Fri, 09 Jun 2023 12:28:33 +0200 [thread overview]
Message-ID: <87mt19c4ku.fsf@secure.mitica> (raw)
In-Reply-To: <20230607161306.31425-3-farosas@suse.de> (Fabiano Rosas's message of "Wed, 7 Jun 2023 13:13:05 -0300")
Fabiano Rosas <farosas@suse.de> wrote:
> This doubly linked list is common for all the multifd and migration
> threads so we need to avoid concurrent access.
>
> Add a mutex to protect the data from concurrent access. This fixes a
> crash when removing two MigrationThread objects from the list at the
> same time during cleanup of multifd threads.
>
> Fixes: 671326201d ("migration: Introduce interface query-migrationthreads")
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2023-06-09 10:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 16:13 [PATCH v2 0/3] migration: Fix multifd cancel test Fabiano Rosas
2023-06-07 16:13 ` [PATCH v2 1/3] migration/multifd: Rename threadinfo.c functions Fabiano Rosas
2023-06-07 16:13 ` [PATCH v2 2/3] migration/multifd: Protect accesses to migration_threads Fabiano Rosas
2023-06-09 10:28 ` Juan Quintela [this message]
2023-06-07 16:13 ` [PATCH v2 3/3] tests/qtest: Re-enable multifd cancel test Fabiano Rosas
2023-06-09 10:30 ` Juan Quintela
2023-06-07 16:24 ` [PATCH v2 0/3] migration: Fix " Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt19c4ku.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=farosas@suse.de \
--cc=jiangjiacheng@huawei.com \
--cc=leobras@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).