From: Juan Quintela <quintela@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [PATCH] configure: unset harmful environment variables
Date: Thu, 25 May 2023 20:51:58 +0200 [thread overview]
Message-ID: <87mt1s452p.fsf@secure.mitica> (raw)
In-Reply-To: <20230525154718.355734-1-pbonzini@redhat.com> (Paolo Bonzini's message of "Thu, 25 May 2023 17:47:18 +0200")
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Apart from CLICOLOR_FORCE and GREP_OPTIONS, there are other variables
> that are listed in the Autoconf manual. While Autoconf neutralizes them
> very early, and assumes it does not (yet) run in a shell that has "unset",
> QEMU assumes that the user invoked configure under a POSIX shell, and
> therefore can simply use "unset" to clear them.
>
> CDPATH is particularly nasty because it messes up "cd ... && pwd".
It is weird that nobody noticed it. I have been using that CDPATH since
last century. Yeap, that makes me definitely old.
> Reported-by: Juan Quintela <quintela@redhat.com>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Tested-by: Juan Quintela <quintela@redhat.com>
Thanks very much.
prev parent reply other threads:[~2023-05-25 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 15:47 [PATCH] configure: unset harmful environment variables Paolo Bonzini
2023-05-25 18:51 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt1s452p.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).