qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Lukas Straub <lukasstraub2@web.de>
Cc: Richard Henderson <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org,  Leonardo Bras <leobras@redhat.com>,
	 Thomas Huth <thuth@redhat.com>,
	 Laurent Vivier <lvivier@redhat.com>,
	 Paolo Bonzini <pbonzini@redhat.com>,
	 Peter Xu <peterx@redhat.com>
Subject: Re: [PULL 00/21] Migration 20230428 patches
Date: Mon, 08 May 2023 10:12:35 +0200	[thread overview]
Message-ID: <87mt2fnswc.fsf@secure.mitica> (raw)
In-Reply-To: <20230508010342.4162c526@gecko.fritz.box> (Lukas Straub's message of "Mon, 8 May 2023 03:06:04 +0200")

Lukas Straub <lukasstraub2@web.de> wrote:
> On Tue, 02 May 2023 12:39:12 +0200
> Juan Quintela <quintela@redhat.com> wrote:
>
>> [...]
>> 
>> my patches are only code movement and cleanups, so Lukas any clue?
>> 
>> Lukas, I am going to drop the compress code for now and pass the other
>> patches.  In the meanwhile, I am going to try to setup some machine
>> where I can run the upstream tests and see if I can reproduce there.
>> BTW, I would be happy if you double check that I did the rebase
>> correctly, they didn't apply correctly, but as said, the tests have been
>> running for two/three days on all my daily testing, so I thought that I
>> did the things correctly.

Hi

> Hi,
> I rebased the series here and got exactly the same files as in this
> pull request. And I can't reproduce these failures either.

Nice

> Maybe you can run the CI just on the newly added compress tests and see
> if it already blows up without the refactoring?

It does, I don't have to check O:-)

The initial reason that I did the compression code on top of multifd was
that I was not able to get the old compression code to run "reliabely"
on my testing.

> Anyway, this series is not so important anymore...

What about:
- I add the series as they are, because the code is better than what we
  have before (and being in a different file makes it easier to
  deprecate, not compile, ...)
- I just disable the tests until we find something that works.

Richard, Lukas?

Later, Juan.

>> Richard, once that we are here, one of the problem that we are having is
>> that the test is exiting with an abort, so we have no clue what is
>> happening.  Is there a way to get a backtrace, or at least the number
>> 
>> Later, Juan.
>> 



  reply	other threads:[~2023-05-08  8:13 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28 19:11 [PULL 00/21] Migration 20230428 patches Juan Quintela
2023-04-28 19:11 ` [PULL 01/21] multifd: We already account for this packet on the multifd thread Juan Quintela
2023-04-28 19:11 ` [PULL 02/21] migration: Move ram_stats to its own file migration-stats.[ch] Juan Quintela
2023-04-28 19:11 ` [PULL 03/21] migration: Rename ram_counters to mig_stats Juan Quintela
2023-04-28 19:11 ` [PULL 04/21] migration: Rename RAMStats to MigrationAtomicStats Juan Quintela
2023-04-28 19:11 ` [PULL 05/21] migration/rdma: Split the zero page case from acct_update_position Juan Quintela
2023-04-28 19:11 ` [PULL 06/21] migration/rdma: Unfold last user of acct_update_position() Juan Quintela
2023-04-28 19:11 ` [PULL 07/21] migration: Drop unused parameter for migration_tls_get_creds() Juan Quintela
2023-04-28 19:11 ` [PULL 08/21] migration: Drop unused parameter for migration_tls_client_create() Juan Quintela
2023-04-28 19:11 ` [PULL 09/21] qtest/migration-test.c: Add tests with compress enabled Juan Quintela
2023-04-28 19:11 ` [PULL 10/21] qtest/migration-test.c: Add postcopy " Juan Quintela
2023-04-28 19:11 ` [PULL 11/21] ram.c: Let the compress threads return a CompressResult enum Juan Quintela
2023-04-28 19:11 ` [PULL 12/21] ram.c: Dont change param->block in the compress thread Juan Quintela
2023-04-28 19:11 ` [PULL 13/21] ram.c: Reset result after sending queued data Juan Quintela
2023-04-28 19:11 ` [PULL 14/21] ram.c: Do not call save_page_header() from compress threads Juan Quintela
2023-04-28 19:11 ` [PULL 15/21] ram.c: Call update_compress_thread_counts from compress_send_queued_data Juan Quintela
2023-04-28 19:11 ` [PULL 16/21] ram.c: Remove last ram.c dependency from the core compress code Juan Quintela
2023-04-28 19:11 ` [PULL 17/21] ram.c: Move core compression code into its own file Juan Quintela
2023-04-28 19:12 ` [PULL 18/21] ram.c: Move core decompression " Juan Quintela
2023-04-28 19:12 ` [PULL 19/21] ram compress: Assert that the file buffer matches the result Juan Quintela
2023-04-28 19:12 ` [PULL 20/21] ram-compress.c: Make target independent Juan Quintela
2023-04-28 19:12 ` [PULL 21/21] migration: Initialize and cleanup decompression in migration.c Juan Quintela
2023-04-29 18:45 ` [PULL 00/21] Migration 20230428 patches Richard Henderson
2023-04-29 20:14   ` Lukas Straub
2023-04-29 22:08     ` Richard Henderson
2023-05-02 10:39   ` Juan Quintela
2023-05-02 10:43     ` Peter Maydell
2023-05-03  9:17       ` Juan Quintela
2023-05-03 12:57         ` Daniel P. Berrangé
2023-05-03 12:57         ` Peter Maydell
2023-05-03 13:29           ` Juan Quintela
2023-05-03 13:58             ` Peter Maydell
2023-05-08  1:06     ` Lukas Straub
2023-05-08  8:12       ` Juan Quintela [this message]
2023-05-08  9:47         ` Lukas Straub

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mt2fnswc.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=leobras@redhat.com \
    --cc=lukasstraub2@web.de \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).