From: Fabiano Rosas <farosas@suse.de>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Alexander Graf" <agraf@csgraf.de>
Subject: Re: [RFC PATCH 19/27] target/arm: Move common cpregs code into a separate file
Date: Thu, 05 Jan 2023 10:12:34 -0300 [thread overview]
Message-ID: <87mt6xnn0d.fsf@suse.de> (raw)
In-Reply-To: <2b66b91d-aae1-a94a-053b-05af0d5d59a7@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> On 1/4/23 13:58, Fabiano Rosas wrote:
>> Code moved verbatim.
>>
>> Signed-off-by: Fabiano Rosas<farosas@suse.de>
>> ---
>> Extracted from:
>> https://lore.kernel.org/r/20210416162824.25131-15-cfontana@suse.de
>> [RFC v14 14/80] target/arm: split cpregs from tcg/helper.c
>> ---
>> target/arm/cpregs.c | 482 +++++++++++++++++++++++++++++++++++++++++
>> target/arm/helper.c | 472 ----------------------------------------
>> target/arm/meson.build | 1 +
>> 3 files changed, 483 insertions(+), 472 deletions(-)
>> create mode 100644 target/arm/cpregs.c
>
> Ok, now I'd like to know what the intended difference between cpregs.c and
> cpustate-list.c. If it were only write_cpustate_to_list and write_list_to_cpustate in the
> latter file, that might be one thing. But get_arm_cp_reginfo definitely belongs in cpregs.c.
Well, to be honest, this came from a reviewed patch from the original
series, so I assumed it had already been discussed and didn't put much
thought into it.
I'll have to rethink this split a little bit due to your comment in
patch 20 anyway, so I might just drop this new file.
Thanks
>
>
> r~
next prev parent reply other threads:[~2023-01-05 13:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 21:58 [RFC PATCH 00/27] target/arm: Allow CONFIG_TCG=n builds Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 01/27] target/arm: Fix checkpatch comment style warnings in helper.c Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 02/27] target/arm: Fix checkpatch space errors " Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 03/27] target/arm: Fix checkpatch brace " Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 04/27] target/arm: Remove unused includes from m_helper.c Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 05/27] target/arm: Remove unused includes from helper.c Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 06/27] target/arm: cleanup cpu includes Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 07/27] target/arm: rename handle_semihosting to tcg_handle_semihosting Fabiano Rosas
2023-01-04 22:22 ` Philippe Mathieu-Daudé
2023-01-04 21:58 ` [RFC PATCH 08/27] target/arm: wrap psci call with tcg_enabled Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 09/27] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled() Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 10/27] target/arm: Move PC alignment check Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 11/27] target/arm: only perform TCG cpu and machine inits if TCG enabled Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 12/27] target/arm: Add tcg/meson.build Fabiano Rosas
2023-01-04 22:23 ` Philippe Mathieu-Daudé
2023-01-04 21:58 ` [RFC PATCH 13/27] target/arm: move translate modules to tcg/ Fabiano Rosas
2023-01-04 22:24 ` Philippe Mathieu-Daudé
2023-01-04 21:58 ` [RFC PATCH 14/27] target/arm: Move regime_using_lpae_format into internal.h Fabiano Rosas
2023-01-05 4:48 ` Richard Henderson
2023-01-04 21:58 ` [RFC PATCH 15/27] target/arm: move helpers to tcg/ Fabiano Rosas
2023-01-05 4:49 ` Richard Henderson
2023-01-04 21:58 ` [RFC PATCH 16/27] target/arm: only build psci for TCG Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 17/27] target/arm: Extract cpustate list manipulation to a file Fabiano Rosas
2023-01-05 4:55 ` Richard Henderson
2023-01-04 21:58 ` [RFC PATCH 18/27] target/arm: Move cpregs code out of cpu.h Fabiano Rosas
2023-01-05 4:55 ` Richard Henderson
2023-01-04 21:58 ` [RFC PATCH 19/27] target/arm: Move common cpregs code into a separate file Fabiano Rosas
2023-01-05 4:58 ` Richard Henderson
2023-01-05 13:12 ` Fabiano Rosas [this message]
2023-01-04 21:58 ` [RFC PATCH 20/27] target/arm: Move cpregs definitions into tcg/cpregs.c Fabiano Rosas
2023-01-05 5:02 ` Richard Henderson
2023-01-04 21:58 ` [RFC PATCH 21/27] target/arm: make further preparation for the exception code to move Fabiano Rosas
2023-01-05 5:02 ` Richard Henderson
2023-01-04 21:58 ` [RFC PATCH 22/27] target/arm: Move hflags code into the tcg directory Fabiano Rosas
2023-01-05 5:09 ` Richard Henderson
2023-01-04 21:58 ` [RFC PATCH 23/27] tests: do not run test-hmp on all machines for ARM KVM-only Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 24/27] tests: do not run qom-test " Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 25/27] tests: device-introspect-test: cope with ARM TCG-only devices Fabiano Rosas
2023-01-04 21:58 ` [RFC PATCH 26/27] cpu-defs.h: Expose CPUTLBEntryFull to non-TCG code Fabiano Rosas
2023-01-05 5:12 ` Richard Henderson
2023-01-05 5:16 ` Richard Henderson
2023-01-04 21:58 ` [RFC PATCH 27/27] target/arm: don't access TCG code when debugging with KVM Fabiano Rosas
2023-01-05 5:19 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt6xnn0d.fsf@suse.de \
--to=farosas@suse.de \
--cc=agraf@csgraf.de \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).