From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org,
"Daniel P . Berrange" <berrange@redhat.com>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v2 4/5] migration: Use non-atomic ops for clear log bitmap
Date: Mon, 14 Nov 2022 15:04:05 +0100 [thread overview]
Message-ID: <87mt8tbpka.fsf@secure.mitica> (raw)
In-Reply-To: <20221004182430.97638-5-peterx@redhat.com> (Peter Xu's message of "Tue, 4 Oct 2022 14:24:29 -0400")
Peter Xu <peterx@redhat.com> wrote:
> Since we already have bitmap_mutex to protect either the dirty bitmap or
> the clear log bitmap, we don't need atomic operations to set/clear/test on
> the clear log bitmap. Switching all ops from atomic to non-atomic
> versions, meanwhile touch up the comments to show which lock is in charge.
>
> Introduced non-atomic version of bitmap_test_and_clear_atomic(), mostly the
> same as the atomic version but simplified a few places, e.g. dropped the
> "old_bits" variable, and also the explicit memory barriers.
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2022-11-15 0:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 18:24 [PATCH v2 0/5] migration: Bug fixes (prepare for preempt-full) Peter Xu
2022-10-04 18:24 ` [PATCH v2 1/5] migration: Fix possible infinite loop of ram save process Peter Xu
2022-11-14 14:02 ` Juan Quintela
2022-10-04 18:24 ` [PATCH v2 2/5] migration: Fix race on qemu_file_shutdown() Peter Xu
2022-11-14 14:02 ` Juan Quintela
2022-10-04 18:24 ` [PATCH v2 3/5] migration: Disallow postcopy preempt to be used with compress Peter Xu
2022-11-14 14:03 ` Juan Quintela
2022-10-04 18:24 ` [PATCH v2 4/5] migration: Use non-atomic ops for clear log bitmap Peter Xu
2022-11-14 14:04 ` Juan Quintela [this message]
2022-10-04 18:24 ` [PATCH v2 5/5] migration: Disable multifd explicitly with compression Peter Xu
2022-10-05 10:49 ` Dr. David Alan Gilbert
2022-11-14 14:04 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt8tbpka.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).