From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44C47C433FE for ; Mon, 28 Mar 2022 11:18:58 +0000 (UTC) Received: from localhost ([::1]:42352 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYnOi-0004gx-UH for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 07:18:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYnN4-0003Hn-0r for qemu-devel@nongnu.org; Mon, 28 Mar 2022 07:17:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:32226) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYnN1-00021D-6J for qemu-devel@nongnu.org; Mon, 28 Mar 2022 07:17:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648466230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iX3wgZB5WXmEpfP1U1qSoo7ed2o2ZOBcgvB8nUhCzzc=; b=g69HxRLS1FA1+piZKLbWWCgOMBtPi837w5a0noEvDdb/rnMzlktCmiYDa2hIg+53OSZ5b3 Ioo/L+5dICHS6b92lk++ptPbG5EVTPDMDdaZO7ZA8b0g+MuthyPLwvsuhZ3jssx1OWJGK0 etbs8m3Ru+jbC6r11oTK4w4F+xukwHw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-661-CTdcRFLiNKCffx9b96PN9w-1; Mon, 28 Mar 2022 07:17:08 -0400 X-MC-Unique: CTdcRFLiNKCffx9b96PN9w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 90C393C11A02 for ; Mon, 28 Mar 2022 11:17:08 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.112.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DF9CA2166B25; Mon, 28 Mar 2022 11:16:55 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A46DB21E691D; Mon, 28 Mar 2022 13:16:54 +0200 (CEST) From: Markus Armbruster To: Victor Toso Subject: Re: [PATCH v2.1] qapi: fix example of BLOCK_IMAGE_CORRUPTED event References: <20220325220707.52118-3-victortoso@redhat.com> <20220328090531.7332-1-victortoso@redhat.com> Date: Mon, 28 Mar 2022 13:16:54 +0200 In-Reply-To: <20220328090531.7332-1-victortoso@redhat.com> (Victor Toso's message of "Mon, 28 Mar 2022 11:05:31 +0200") Message-ID: <87mtha9vix.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Victor Toso writes: > Example output lacks mandatory member @fatal. Provide it. > > Example output shows a value of @msg no version of the code > produces. No big deal, but replace it anyway by one that > today's code does produce. > > Signed-off-by: Victor Toso > --- > qapi/block-core.json | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index e89f2dfb5b..63c30a5378 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -5006,10 +5006,9 @@ > # Example: > # > # <- { "event": "BLOCK_IMAGE_CORRUPTED", > -# "data": { "device": "ide0-hd0", "node-name": "node0", > -# "msg": "Prevented active L1 table overwrite", "offset": 196608, > -# "size": 65536 }, > -# "timestamp": { "seconds": 1378126126, "microseconds": 966463 } } > +# "data": { "device": "", "node-name": "drive", "fatal": false, > +# "msg": "L2 table offset 0x2a2a2a00 unaligned (L1 index: 0)" }, > +# "timestamp": { "seconds": 1648243240, "microseconds": 906060 } } > # > # Since: 1.7 > ## Reviewed-by: Markus Armbruster