From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9ADEC07E95 for ; Fri, 16 Jul 2021 11:57:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64C95613CF for ; Fri, 16 Jul 2021 11:57:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64C95613CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m4MTZ-00005p-9q for qemu-devel@archiver.kernel.org; Fri, 16 Jul 2021 07:57:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4MST-0007ln-V8 for qemu-devel@nongnu.org; Fri, 16 Jul 2021 07:56:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59308) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m4MSQ-00039t-Rx for qemu-devel@nongnu.org; Fri, 16 Jul 2021 07:56:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626436601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F8M8YOOX3a03oJVCWAzC/F8ej5s2oo+IFuLdrWLOKeo=; b=DrXgraMplG9J23//Zb5EGWojdi3QuLDZPqtR/MMUplwdiSpgTnftIiEyPPmrDrd7WONhcV ZkENND0EPGRgABdWlE8grh+vQXxyd/gjPf5OLaA4uKnXaTij1WLq1WyUHVyjUHWEwL/v05 x9ZQEyBDveiLCBJx4raYJ7u4s0sF2TU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-177-UFcqFrLSOhilsVG7ztwXRw-1; Fri, 16 Jul 2021 07:56:40 -0400 X-MC-Unique: UFcqFrLSOhilsVG7ztwXRw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF00A36262; Fri, 16 Jul 2021 11:56:38 +0000 (UTC) Received: from localhost (ovpn-112-169.ams2.redhat.com [10.36.112.169]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB9685C1A1; Fri, 16 Jul 2021 11:56:30 +0000 (UTC) From: Cornelia Huck To: Pierre Morel , qemu-s390x@nongnu.org Subject: Re: [PATCH v1 6/9] s390x: kvm: topology: interception of PTF instruction In-Reply-To: <4eee89ff-1407-9f82-a7e4-f8a1093994b5@linux.ibm.com> Organization: Red Hat GmbH References: <1626281596-31061-1-git-send-email-pmorel@linux.ibm.com> <1626281596-31061-7-git-send-email-pmorel@linux.ibm.com> <87v95aboky.fsf@redhat.com> <4eee89ff-1407-9f82-a7e4-f8a1093994b5@linux.ibm.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Fri, 16 Jul 2021 13:56:29 +0200 Message-ID: <87mtqmbhg2.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, ehabkost@redhat.com, david@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, armbru@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, pbonzini@redhat.com, eblake@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jul 16 2021, Pierre Morel wrote: > On 7/16/21 11:22 AM, Cornelia Huck wrote: >> On Wed, Jul 14 2021, Pierre Morel wrote: >> >>> Interception of the PTF instruction depending on the new >>> KVM_CAP_S390_CPU_TOPOLOGY KVM extension. >> >> Wasn't that the capability that you dropped? > > yes, > >> >> Is PTF supposed to be always intercepting? If that isn't configurable, >> wouldn't older QEMUs generate exceptions for it? I'm a bit confused. > > Yes, PTF generated an OPERATION exception on old QEMU, but was not used > by the guest if it has not the topology facility 11. > > So just as for STSI, I think we need the KVM_CAP_S390_CPU_TOPOLOGY I > dropped because otherwise, now that the kernel will advertise facility > 11, the guest will use it and it will get the exception that it should > not get. Ok, makes sense.