From: Juan Quintela <quintela@redhat.com>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Stefan Berger" <stefanb@linux.ibm.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v2 3/3] savevm: check RAM is pagesize aligned
Date: Fri, 28 Feb 2020 08:55:16 +0100 [thread overview]
Message-ID: <87mu93b0yj.fsf@secure.laptop> (raw)
In-Reply-To: <CAL1e-=h+SkEPy1VVvdNeo9T1mAT5-dA7orsj0TFtfDsTofwzFg@mail.gmail.com> (Aleksandar Markovic's message of "Thu, 27 Feb 2020 22:00:27 +0100")
Aleksandar Markovic <aleksandar.m.mail@gmail.com> wrote:
> On Thursday, February 27, 2020, Juan Quintela <quintela@redhat.com> wrote:
>
> Marc-André Lureau <marcandre.lureau@gmail.com> wrote:
> > Hi Juan
> >
> > On Wed, Jan 8, 2020 at 2:08 PM Juan Quintela <quintela@redhat.com> wrote:
> >>
> >> Marc-André Lureau <marcandre.lureau@redhat.com> wrote:
> >> n> Check the host pointer is correctly aligned, otherwise we may fail
> >> > during migration in ram_block_discard_range().
> >> >
> >> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> >>
> >> Reviewed-by: Juan Quintela <quintela@redhat.com>
> >>
> >> queued
> >>
> >
> > Did it get lost? thanks
>
> I dropped it in the past, because it made "make check" for mips fail.
> (I put it on my ToDo list to investigate and forgot about it)
>
> Thank you for caring for mips.
You are welcome.
But you need to thank "make check"
It didn't pass.
> Do you perhaps remember what was tgevtest and environment for the failing test?
It was plain "make check" with everything under the sun compiled in.
Clearly it was other of the patches, or an interaction between them what
failed.
I don't remember the error, sorry. I droped the patch to my ToDo list
of things to investigate (the patch was "obviously" correct) and forgot
about it.
Later, Juan.
next prev parent reply other threads:[~2020-02-28 7:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 7:39 [PATCH v2 0/3] tpm: fix PPI RAM migration Marc-André Lureau
2020-01-03 7:39 ` [PATCH v2 1/3] misc: use QEMU_IS_ALIGNED Marc-André Lureau
2020-01-03 7:43 ` Philippe Mathieu-Daudé
2020-01-03 7:59 ` Marc-André Lureau
2020-01-03 10:21 ` Philippe Mathieu-Daudé
2020-01-03 16:36 ` Stefan Berger
2020-01-08 17:06 ` Paolo Bonzini
2020-01-08 18:55 ` Juan Quintela
2020-01-03 7:39 ` [PATCH v2 2/3] tpm-ppi: page-align PPI RAM Marc-André Lureau
2020-01-03 10:02 ` Dr. David Alan Gilbert
2020-01-03 16:38 ` Stefan Berger
2020-01-08 11:29 ` Dr. David Alan Gilbert
2020-01-08 12:49 ` Marc-André Lureau
2020-01-03 7:40 ` [PATCH v2 3/3] savevm: check RAM is pagesize aligned Marc-André Lureau
2020-01-03 7:43 ` Philippe Mathieu-Daudé
2020-01-08 12:47 ` Juan Quintela
2020-02-17 11:33 ` Marc-André Lureau
2020-02-27 18:41 ` Juan Quintela
2020-02-27 21:00 ` Aleksandar Markovic
2020-02-28 7:55 ` Juan Quintela [this message]
2020-02-28 9:09 ` Juan Quintela
2020-02-28 10:30 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu93b0yj.fsf@secure.laptop \
--to=quintela@redhat.com \
--cc=aleksandar.m.mail@gmail.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).