From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqc5z-0005Qk-9F for qemu-devel@nongnu.org; Fri, 17 Aug 2018 06:35:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqc5u-0000Ot-Vx for qemu-devel@nongnu.org; Fri, 17 Aug 2018 06:35:07 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38588 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fqc5u-0000Od-RK for qemu-devel@nongnu.org; Fri, 17 Aug 2018 06:35:02 -0400 From: Juan Quintela In-Reply-To: <1534419358-10932-7-git-send-email-thuth@redhat.com> (Thomas Huth's message of "Thu, 16 Aug 2018 13:35:56 +0200") References: <1534419358-10932-1-git-send-email-thuth@redhat.com> <1534419358-10932-7-git-send-email-thuth@redhat.com> Reply-To: quintela@redhat.com Date: Fri, 17 Aug 2018 12:34:52 +0200 Message-ID: <87mutluvqr.fsf@trasno.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 6/8] tests/device-introspection: Check that the qom-tree and qtree do not change List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: qemu-devel@nongnu.org, Markus Armbruster , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Eric Blake , "Dr. David Alan Gilbert" , "Michael S. Tsirkin" , Paolo Bonzini , Laurent Vivier Thomas Huth wrote: > Introspection should not change the qom-tree / qtree, so we should check > this in the device-introspect-test, too. This patch helped to find lots > of instrospection bugs during the QEMU v3.0 soft/hard-freeze period in the > last two months. > > Signed-off-by: Thomas Huth Reviewed-by: Juan Quintela