qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Jayanto Minocha <jayanto@gmail.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Tracing guest virtual addresses
Date: Wed, 21 Jun 2017 15:44:22 +0100	[thread overview]
Message-ID: <87mv91tn7d.fsf@linaro.org> (raw)
In-Reply-To: <CAFEAcA-434=WhBxC=KB2HBhrPG9b+z1i3jqeFgiE=H8ceZJYzg@mail.gmail.com>


Peter Maydell <peter.maydell@linaro.org> writes:

> On 20 June 2017 at 12:02, Lluís Vilanova <vilanova@ac.upc.edu> wrote:
>> Jayanto Minocha writes:
>>> But that is only used to instrument the cpu_ld/cpu_st macros, which is only
>>> called in the case of a tlb miss.
>>
>>> I've been going over the archives, and it looks like I need to instrument
>>> tcg_out_tlb_load. Am I on the right path ?
>>
>> That event should trace all guest memory accesses performed by the CPU. If you
>> found any case where this does not hold, it is likely a bug and I'd appreciate
>> it if you can point me to the smallest possible failing example.
>
> Does it catch memory accesses that are performed via helper functions,
> or only ones done by inline TCG code?

AFAICT it inserts a helper call on the TCG ld/st ops. I wonder why not
just ensure we always take the slow path and put the helpers in the
access functions there? You could even apply an address mask if you only
want to look at certain address ranges.

>
> thanks
> -- PMM


--
Alex Bennée

  reply	other threads:[~2017-06-21 14:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19 21:15 [Qemu-devel] Tracing guest virtual addresses Jayanto Minocha
2017-06-20 11:02 ` Lluís Vilanova
2017-06-20 11:13   ` Peter Maydell
2017-06-21 14:44     ` Alex Bennée [this message]
2017-06-25 12:20       ` Lluís Vilanova
2017-06-25 17:35         ` Alex Bennée
2017-06-26  9:26           ` Lluís Vilanova
2017-06-26  9:32             ` Peter Maydell
2017-06-26 12:04               ` Lluís Vilanova
2017-06-26 12:14                 ` Peter Maydell
2017-06-20 17:20   ` Emilio G. Cota
2017-06-20 22:30     ` Jayanto Minocha
2017-06-22  5:36       ` Lluís Vilanova
2017-06-25 12:16         ` Lluís Vilanova
2017-06-26 17:42           ` Emilio G. Cota

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mv91tn7d.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=jayanto@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).