From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csm1W-0005id-E8 for qemu-devel@nongnu.org; Tue, 28 Mar 2017 03:58:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csm1S-0002Hy-8a for qemu-devel@nongnu.org; Tue, 28 Mar 2017 03:58:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58514) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1csm1S-0002HA-3G for qemu-devel@nongnu.org; Tue, 28 Mar 2017 03:58:34 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CB4A564D81 for ; Tue, 28 Mar 2017 07:58:30 +0000 (UTC) From: Markus Armbruster References: <1490621195-2228-1-git-send-email-armbru@redhat.com> <1490621195-2228-10-git-send-email-armbru@redhat.com> <20170328023240.GP15423@localhost.localdomain> <20170328035106.GA1135@localhost.localdomain> Date: Tue, 28 Mar 2017 09:58:28 +0200 In-Reply-To: <20170328035106.GA1135@localhost.localdomain> (Jeff Cody's message of "Mon, 27 Mar 2017 23:51:06 -0400") Message-ID: <87mvc56dej.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, jdurgin@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Jeff Cody writes: > On Mon, Mar 27, 2017 at 10:32:40PM -0400, Jeff Cody wrote: >> On Mon, Mar 27, 2017 at 03:26:33PM +0200, Markus Armbruster wrote: >> > This reverts a part of commit 8a47e8e. We're having second thoughts >> > on the QAPI schema (and thus the external interface), and haven't >> > reached consensus, yet. Issues include: >> > >> > * BlockdevOptionsRbd member @password-secret isn't actually a >> > password, it's a key generated by Ceph. >> > >> > * We're not sure where member @password-secret belongs (see the >> > previous commit). >> > >> > * How @password-secret interacts with settings from a configuration >> > file specified with @conf is undocumented. I suspect it's untested, >> > too. >> >> It's tested, at least to some extent -- it works on my setup; it will >> override whatever is set in the conf or the keyring. I can alternate >> between /etc/ceph/keyring, or password-secret, or override the user present >> in /etc/cep/keyring with a different key via password-secret. >> >> So I'd suggest dropping that blurb from the commit message. Of course. >> I agree with the overall reasoning though behind remove all parameters not >> needed for now, so: >> >> Reviewed-by: Jeff Cody >> > > Wait, hold up on that R-b :) > > This only seems to revert the comment in the QAPI. You meant to remove the > entry from the BlockdevOptionsRbd struct too, right? D'oh! Suspect a rebase accident... I'll drop the member and keep your R-by.