From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a99Gq-0007Sn-Ai for qemu-devel@nongnu.org; Wed, 16 Dec 2015 05:25:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a99Gm-0004RW-An for qemu-devel@nongnu.org; Wed, 16 Dec 2015 05:25:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a99Gm-0004RQ-5Y for qemu-devel@nongnu.org; Wed, 16 Dec 2015 05:25:16 -0500 From: Juan Quintela In-Reply-To: <1450206170-26901-2-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Tue, 15 Dec 2015 19:02:45 +0000") References: <1450206170-26901-1-git-send-email-dgilbert@redhat.com> <1450206170-26901-2-git-send-email-dgilbert@redhat.com> Date: Wed, 16 Dec 2015 11:25:04 +0100 Message-ID: <87mvtawv0f.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 1/6] migration: Export migrate_set_state() Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: amit.shah@redhat.com, jdenemar@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com "Dr. David Alan Gilbert (git)" wrote: > From: zhanghailiang > > Fix the first parameter of migrate_set_state(), and export it. > We will use it in later. > > Signed-off-by: zhanghailiang > Reviewed-by: Dr. David Alan Gilbert Why do we need to change the prototype? If you don't have a MigrationState, you can't get the pointer that you need to change. I am missing something obvious?