From: Juan Quintela <quintela@redhat.com>
To: Liang Li <liang.z.li@intel.com>
Cc: amit.shah@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] fix the flaws of qemu_put_compression_data
Date: Fri, 04 Dec 2015 12:02:38 +0100 [thread overview]
Message-ID: <87mvtqjx2p.fsf@emacs.mitica> (raw)
In-Reply-To: <1449201128-22779-1-git-send-email-liang.z.li@intel.com> (Liang Li's message of "Fri, 4 Dec 2015 11:52:06 +0800")
Liang Li <liang.z.li@intel.com> wrote:
> This patch fixed the flaws in qemu_put_compression_data function.
> and cleanup the code based on the change.
Hi
We are in hard freeze. My understanding is that this are
"optimizations" that can wait for 2.6:
- my understanding from commit from message one and from quick look at
the code is that this change is not needed for current users, is that correct?
- we avoid a copy at the beginning of each block (micro-optimization)
If my understanding is correct, I am delaying this two patches to 2.6.
What do you think?
Later, Juan.
BTW, amit address was wrongly typed, I just fixed it.
>
> Liang Li (2):
> qemu-file: fix flaws of qemu_put_compression_data
> migration: code clean up.
>
> migration/qemu-file.c | 10 +++++++++-
> migration/ram.c | 20 ++++++++------------
> 2 files changed, 17 insertions(+), 13 deletions(-)
next prev parent reply other threads:[~2015-12-04 11:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 3:52 [Qemu-devel] [PATCH 0/2] fix the flaws of qemu_put_compression_data Liang Li
2015-12-04 3:52 ` [Qemu-devel] [PATCH 1/2] qemu-file: fix " Liang Li
2015-12-04 11:07 ` Juan Quintela
2015-12-04 14:25 ` Li, Liang Z
2015-12-04 19:44 ` Juan Quintela
2015-12-06 14:29 ` Li, Liang Z
2015-12-07 7:09 ` Stefan Hajnoczi
2015-12-07 7:09 ` Stefan Hajnoczi
2015-12-07 7:12 ` Li, Liang Z
2015-12-04 3:52 ` [Qemu-devel] [PATCH 2/2] migration: code clean up Liang Li
2015-12-04 11:02 ` Juan Quintela [this message]
2015-12-04 13:36 ` [Qemu-devel] [PATCH 0/2] fix the flaws of qemu_put_compression_data Li, Liang Z
-- strict thread matches above, loose matches on Subject: below --
2015-12-04 3:53 Liang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvtqjx2p.fsf@emacs.mitica \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=liang.z.li@intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).