From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4o8d-0002ts-K0 for qemu-devel@nongnu.org; Fri, 04 Dec 2015 06:02:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4o8Z-0005St-Ch for qemu-devel@nongnu.org; Fri, 04 Dec 2015 06:02:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4o8Z-0005Sn-7k for qemu-devel@nongnu.org; Fri, 04 Dec 2015 06:02:51 -0500 From: Juan Quintela In-Reply-To: <1449201128-22779-1-git-send-email-liang.z.li@intel.com> (Liang Li's message of "Fri, 4 Dec 2015 11:52:06 +0800") References: <1449201128-22779-1-git-send-email-liang.z.li@intel.com> Date: Fri, 04 Dec 2015 12:02:38 +0100 Message-ID: <87mvtqjx2p.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 0/2] fix the flaws of qemu_put_compression_data Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li Cc: amit.shah@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com Liang Li wrote: > This patch fixed the flaws in qemu_put_compression_data function. > and cleanup the code based on the change. Hi We are in hard freeze. My understanding is that this are "optimizations" that can wait for 2.6: - my understanding from commit from message one and from quick look at the code is that this change is not needed for current users, is that correct? - we avoid a copy at the beginning of each block (micro-optimization) If my understanding is correct, I am delaying this two patches to 2.6. What do you think? Later, Juan. BTW, amit address was wrongly typed, I just fixed it. > > Liang Li (2): > qemu-file: fix flaws of qemu_put_compression_data > migration: code clean up. > > migration/qemu-file.c | 10 +++++++++- > migration/ram.c | 20 ++++++++------------ > 2 files changed, 17 insertions(+), 13 deletions(-)