From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhNHH-0004Qr-HG for qemu-devel@nongnu.org; Tue, 28 May 2013 13:01:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhNH8-0006fW-At for qemu-devel@nongnu.org; Tue, 28 May 2013 13:01:39 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:33329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhNH7-0006em-Na for qemu-devel@nongnu.org; Tue, 28 May 2013 13:01:30 -0400 Received: from /spool/local by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 29 May 2013 02:52:35 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 61A053578052 for ; Wed, 29 May 2013 03:01:21 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4SGkuT514745638 for ; Wed, 29 May 2013 02:46:56 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4SH1Ka3017150 for ; Wed, 29 May 2013 03:01:21 +1000 From: Anthony Liguori In-Reply-To: References: <1366662589-18315-1-git-send-email-peter.maydell@linaro.org> Date: Tue, 28 May 2013 12:01:16 -0500 Message-ID: <87mwrfca3n.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v3 0/4] ui/cocoa.m: Fix compiler and runtime warnings on 10.8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Andreas =?utf-8?Q?F=C3=A4rber?= , patches@linaro.org Peter Maydell writes: > Ping again! This patchset has now been on the list for eleven > weeks without any review. Objective C is a foreign language. Andreas is the Cocoa maintainer so I've been waiting for him. Andreas, if you don't have time to look at these patches, I can apply them directly. Regards, Anthony Liguori > > thanks > -- PMM > > On 2 May 2013 11:29, Peter Maydell wrote: >> Ping! >> >> -- PMM >> >> On 22 April 2013 21:29, Peter Maydell wrote: >>> These patches fix various compiler and runtime warnings QEMU provokes >>> on MacOSX 10.8. The first two fix a leak and some deprecated functions >>> which cause warnings in the system log when QEMU runs. The second >>> two avoid some functions which cause compile time warnings about >>> use of functions deprecated in 10.6. >>> >>> I believe from my reading of the documentation that these changes >>> should still work OK on 10.3, but I don't have any way of testing that. >>> >>> Andreas: I don't write much ObjC so I don't really have a feel for >>> what is good coding style. I mostly tried to follow the existing >>> code (eg "//" style comments) and QEMU's C style (eg 80 cols max). >>> I'm happy to change any of the indentation or whatever to suit your >>> preferences. >>> >>> With this patch set the only remaining compile time warnings from clang >>> on 10.8 are about deprecated methods in audio/coreaudio.c. >>> >>> Changes v2->v3: >>> * rebased again >>> Changes v1->v2: >>> * rebased and fixed up following recent console changes >>> >>> Peter Maydell (4): >>> ui/cocoa.m: Fix leaks of NSScreen and NSConcreteMapTable >>> ui/cocoa.m: Avoid deprecated CPS* functions >>> ui/cocoa.m: Avoid deprecated NSOpenPanel filename method >>> ui/cocoa.m: Avoid deprecated NSOpenPanel beginSheetForDirectory >>> >>> ui/cocoa.m | 52 ++++++++++++++++++++++++++++++++-------------------- >>> 1 file changed, 32 insertions(+), 20 deletions(-) >>> >>> -- >>> 1.7.11.4 >>> >>>