From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO8hB-0001nW-CK for qemu-devel@nongnu.org; Fri, 05 Apr 2013 11:36:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UO8h8-0002KP-0R for qemu-devel@nongnu.org; Fri, 05 Apr 2013 11:36:53 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:59083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UO8h7-0002Js-FJ for qemu-devel@nongnu.org; Fri, 05 Apr 2013 11:36:49 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 6 Apr 2013 01:31:12 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id CA6082CE804A for ; Sat, 6 Apr 2013 02:36:38 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r35FaXOq8323360 for ; Sat, 6 Apr 2013 02:36:33 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r35Faba1003939 for ; Sat, 6 Apr 2013 02:36:38 +1100 From: Anthony Liguori In-Reply-To: <1365085745-14385-1-git-send-email-fred.konrad@greensocs.com> References: <1365085745-14385-1-git-send-email-fred.konrad@greensocs.com> Date: Fri, 05 Apr 2013 10:36:26 -0500 Message-ID: <87mwtdgfb9.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v5 0/7] virtio-serial refactoring. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com, qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, peter.maydell@linaro.org, mark.burton@greensocs.com fred.konrad@greensocs.com writes: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-serial device which extends virtio-device. > Then a virtio-serial can be connected on a virtio-bus. > virtio-serial-pci, virtio-serial-s390 and virtio-serial-ccw are created too, > they extend respectively virtio-pci, virtio-s390-device, virtio-ccw-device and > have a virtio-serial. > > You can checkout my branch here: > > git://project.greensocs.com/qemu-virtio.git virtio-serial-v5 > > Note that it is nearly the same series as virtio-blk and virtio-scsi > refactoring. /home/aliguori/build/qemu/x86_64-softmmu/qemu-system-x86_64 -kernel /usr/local/share/qemu-jeos/kernel-x86_64-pc -initrd .tmp-11584/initramfs-11584.img.gz -device isa-debug-exit -append console=ttyS0 seed=42872 -nographic -enable-kvm -hda .tmp-11584/disk-11584.img -M pc-0.13 -drive file=.tmp-11584/disk-11584.img,if=virtio,snapshot=on -device virtio-balloon-pci -device virtio-serial -net nic,model=virtio -net user -pidfile .tmp-11584/pidfile-11584.pid -qmp unix:.tmp-11584/qmpsock-11584.sock,server,nowait qemu-system-x86_64: -device virtio-serial: No 'virtio-bus' bus found for device 'virtio-serial' I think we need to go back and name the devices 'virtio-serial-device' et al to avoid breaking aliases. Regards, Anthony Liguori > > I made basic tests (with linux guests) on: > * qemu-system-i386 > > Changes v4 -> v5: > * Fixed rebase issue with nvector and the clarifying comment. > * Changed property macro for s390 and ccw device too. > > Changes v3 -> v4: > * Removed serial configuration field ommited in VirtioCCWDevice structure. > > Changes v2 -> v3: > * Added CCW device. > * Rebased. > > Thanks, > > Fred > > KONRAD Frederic (7): > virtio-serial: add the virtio-serial device. > virtio-serial-pci: switch to the new API. > virtio-serial-s390: switch to the new API. > virtio-serial-ccw: switch to the new API. > virtio-serial: cleanup: init and exit functions. > virtio-serial: cleanup: use QOM casts. > virtio-serial: cleanup: remove qdev field. > > hw/s390x/s390-virtio-bus.c | 31 +++++---- > hw/s390x/s390-virtio-bus.h | 12 +++- > hw/s390x/virtio-ccw.c | 29 +++++---- > hw/s390x/virtio-ccw.h | 12 +++- > hw/virtio-pci.c | 131 +++++++++++++++++++------------------ > hw/virtio-pci.h | 14 +++- > hw/virtio-serial-bus.c | 157 +++++++++++++++++++++++++++------------------ > hw/virtio-serial.h | 13 +++- > 8 files changed, 239 insertions(+), 160 deletions(-) > > -- > 1.7.11.7