From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNTqU-0006cS-EB for qemu-devel@nongnu.org; Wed, 03 Apr 2013 15:59:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNTqS-0002nR-1l for qemu-devel@nongnu.org; Wed, 03 Apr 2013 15:59:46 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:53655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNTqR-0002mY-Ha for qemu-devel@nongnu.org; Wed, 03 Apr 2013 15:59:44 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 4 Apr 2013 05:52:19 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id BE6DD2CE804A for ; Thu, 4 Apr 2013 06:59:27 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r33JkGcM4391234 for ; Thu, 4 Apr 2013 06:46:17 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r33JxQCx000571 for ; Thu, 4 Apr 2013 06:59:26 +1100 From: Anthony Liguori In-Reply-To: <514B00C8.2090200@redhat.com> References: <1363821803-3380-1-git-send-email-lersek@redhat.com> <1363821803-3380-5-git-send-email-lersek@redhat.com> <514A4A1A.6000105@redhat.com> <514A54E7.4060800@redhat.com> <514AE3F4.9050002@redhat.com> <514AF446.4020004@redhat.com> <20130321123607.GD32484@redhat.com> <514B004B.6070800@redhat.com> <514B00C8.2090200@redhat.com> Date: Wed, 03 Apr 2013 14:59:20 -0500 Message-ID: <87mwtfcrmv.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Laszlo Ersek Cc: qemu-devel@nongnu.org, kraxel@redhat.com, "Michael S. Tsirkin" Paolo Bonzini writes: > Il 21/03/2013 13:42, Laszlo Ersek ha scritto: >> On 03/21/13 13:36, Michael S. Tsirkin wrote: >>> On Thu, Mar 21, 2013 at 12:51:34PM +0100, Paolo Bonzini wrote: >>>> Il 21/03/2013 11:41, Laszlo Ersek ha scritto: >>>>> On 03/21/13 01:31, Laszlo Ersek wrote: >>>>>> On 03/21/13 00:45, Eric Blake wrote: >>>>>>> On 03/20/2013 05:23 PM, Laszlo Ersek wrote: >>>>> >>>>>>>> +# >>>>>>>> +# @oem_id: #optional OEM identifier (6 bytes) >>>>>>> >>>>>>> s/oem_id/oem-id/ >>>>>>> >>>>>>> In general, new QMP interfaces should use '-', not '_'. >>>>>> >>>>>> Indeed! I think this warrants a respin. >>>>> >>>>> Actually it doesn't, apologies -- I got confused for a minute. Again, >>>>> since I aim to match the existing option format, I must keep the same >>>>> spelling. >>>> >>>> We should make a list of places where we have mixed conventions, accept >>>> both, and mass-convert to dash... >>>> >>>> Paolo >>> >>> Anthony used to nack all mass conversions since they mess up the git >>> history. Since the movement of headers went in, I gather this position >>> has been relaxed... >>> >> >> Paolo, what are you suggesting precisely? > > Using something like > > int strcmp_dash(const char *a, const char *b) > { > char p, q; > for (;; a++, b++) { > p = *a == '_' ? '-' : *a; > q = *b == '_' ? '-' : *b; > a++, b++; > } while (p == q && p != 0); > return p - q; > } > > in QemuOpts, the monitor, etc. The mass conversion isn't really > necessary, just for cleanliness. I had thought we already did this for qemu-option.c but it doesn't appear that we do... Regards, Anthony Liguori > > Paolo