From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41132)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TmsFd-00066V-WE
	for qemu-devel@nongnu.org; Sun, 23 Dec 2012 15:34:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TmsFc-0007ro-Gd
	for qemu-devel@nongnu.org; Sun, 23 Dec 2012 15:34:25 -0500
Received: from mail-ob0-f175.google.com ([209.85.214.175]:42689)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TmsFc-0007rb-CO
	for qemu-devel@nongnu.org; Sun, 23 Dec 2012 15:34:24 -0500
Received: by mail-ob0-f175.google.com with SMTP id vb8so6284743obc.34
	for <qemu-devel@nongnu.org>; Sun, 23 Dec 2012 12:34:23 -0800 (PST)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <1355175187-11470-1-git-send-email-imammedo@redhat.com>
References: <1355175187-11470-1-git-send-email-imammedo@redhat.com>
Date: Sun, 23 Dec 2012 14:34:21 -0600
Message-ID: <87mwx4tsmq.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 0/2 v2] introduce visitor for parsing
	suffixed integer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com, afaerber@suse.de, ehabkost@redhat.com

Igor Mammedov <imammedo@redhat.com> writes:

> v2:
>  * Naming changes:
>     - s/visit_type_uint_suffixed_int/visit_type_suffixed_int/
>     - use 'suffix_factor' instead of 'unit'
>  * Added  documentation to visit_type_suffixed_int()
>  * Fixed errp check.
>  * Style fixes

This is not how visitors are supposed to be used.

Just treat tsc_freq as a string property and parse it in the setter.

Regards,

Anthony Liguori

>
> Reference to previous version dicussion:
>     http://lists.gnu.org/archive/html/qemu-devel/2012-12/msg00758.html
>
> Git tree for testing:
>     https://github.com/imammedo/qemu/tree/type_suffixed_int_v2
>
> Igor Mammedov (2):
>   add visitor for parsing int[KMGT] input string
>   target-i386: use visit_type_suffixed_int() to parse tsc_freq property
>     value
>
>  qapi/qapi-dealloc-visitor.c |  8 ++++++++
>  qapi/qapi-visit-core.c      | 35 +++++++++++++++++++++++++++++++++++
>  qapi/qapi-visit-core.h      |  4 ++++
>  qapi/string-input-visitor.c | 25 +++++++++++++++++++++++++
>  target-i386/cpu.c           |  3 ++-
>  5 files changed, 74 insertions(+), 1 deletion(-)
>
> -- 
> 1.7.11.7