From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQeTI-0001aN-6s for qemu-devel@nongnu.org; Tue, 23 Oct 2012 09:24:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQeTB-0002EB-QM for qemu-devel@nongnu.org; Tue, 23 Oct 2012 09:24:40 -0400 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:34279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQeTB-0002Dv-3G for qemu-devel@nongnu.org; Tue, 23 Oct 2012 09:24:33 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Oct 2012 18:54:27 +0530 From: Anthony Liguori In-Reply-To: <1A23CBFB-5BF8-45A3-A7FB-9E00E6D18AA1@suse.de> References: <1350986975-21786-1-git-send-email-aviksil@linux.vnet.ibm.com> <1350986975-21786-2-git-send-email-aviksil@linux.vnet.ibm.com> <1A23CBFB-5BF8-45A3-A7FB-9E00E6D18AA1@suse.de> Date: Tue, 23 Oct 2012 08:24:06 -0500 Message-ID: <87mwzds4nd.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 1/2] Make default boot order machine specific List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Avik Sil Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au Alexander Graf writes: > On 23.10.2012, at 12:09, Avik Sil wrote: > >> This patch makes default boot order machine specific instead of >> set globally. The default boot order can be set per machine in >> QEMUMachine default_machine_opts, or by the command line using >> -machine ,boot=, or by standard -boot >> option. This allows a machine to receive a NULL boot order when >> -boot isn't used and take an appropriate action accordingly. This >> helps machine boots from the devices as set in guest's non-volatile >> memory location in case no boot order is provided by the user. >> >> Signed-off-by: Avik Sil >> --- >> hw/nseries.c | 2 ++ >> hw/pc_piix.c | 13 ++++++++++++- >> hw/ppc_newworld.c | 1 + >> hw/ppc_oldworld.c | 1 + >> hw/ppc_prep.c | 1 + >> hw/sun4m.c | 10 ++++++++++ >> hw/sun4u.c | 3 +++ > > That feels like too much magic for my taste. Can't we have some > default macro (or even the explicit "cad" thing) that we push to > _every_ machine description out there? The next patch to implement > boot= for pseries would then remove this default value for the pseries > machine. I agree, having a default macro would avoid having to touch everything again for the next addition. Regards, Anthony Liguori > > The way the patch works right now, the "make machine specific" patch indirectly also changes the behavior for a bunch of machines. > > > Alex