From: Anthony Liguori <aliguori@us.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
patches@linaro.org, qemu-devel@nongnu.org,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] qom: Reject attempts to add a property that already exists
Date: Mon, 08 Oct 2012 12:06:16 -0500 [thread overview]
Message-ID: <87mwzwrj07.fsf@codemonkey.ws> (raw)
In-Reply-To: <CAFEAcA-VjSpM+wKaOHCQGvn3WuBdNuwA1XFDgD8pG5rurv=i4A@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 8 October 2012 14:29, Anthony Liguori <aliguori@us.ibm.com> wrote:
>> This is wrong.
>>
>> Container properties are added by the user. You will turn a gracefully
>> failure (during hotplug) into an abort().
>
> No, it's turning a bug into an abort -- we don't handle trying to
> create two identically named properties correctly today.
Killing a guest because of something a user mistypes is not very friendly.
>
>> Please limit this to static properties as they are not added by a user.
>
> Adding two dynamic properties of the same name is also not
> going to work and we need to do something with it...
Raise an error.
> What is the code path for properties being added by a user?
qdev_device_add().
> If it's qdev_device_add() then that code presumably doesn't
> care about graceful failures because it passes NULL as an
> error pointer.
Then we should handle the error there gracefully.
> container_get() seems to assume that adding the
> child property will always succeed and will not do the right
> thing if there already exists a child property of the relevant
> name but wrong type.
>
> Basically it seems to me that any code which might actually
> be hit by this assert() rather needs examination and rewriting
> to handle the error case anyway...
There are only two cases that actually matter today:
1) static properties
2) qdev_device_add().
Yes, (2) is not doign error checking today. It should. I would be very
happy with an abort() in (1) since that's clearly a programming bug.
Regards,
Anthony Liguori
>
> -- PMM
prev parent reply other threads:[~2012-10-08 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 13:55 [Qemu-devel] [PATCH v2] qom: Reject attempts to add a property that already exists Peter Maydell
2012-09-07 14:13 ` Andreas Färber
2012-10-08 13:00 ` Peter Maydell
2012-10-08 13:29 ` Anthony Liguori
2012-10-08 13:38 ` Peter Crosthwaite
2012-10-08 13:57 ` Peter Maydell
2012-10-08 13:47 ` Peter Maydell
2012-10-08 17:06 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwzwrj07.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).