From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47908)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Rxehe-0000gY-S2
	for qemu-devel@nongnu.org; Wed, 15 Feb 2012 08:15:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1RxehQ-0007RD-Ov
	for qemu-devel@nongnu.org; Wed, 15 Feb 2012 08:15:22 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46623)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1RxehQ-0007Pk-H3
	for qemu-devel@nongnu.org; Wed, 15 Feb 2012 08:15:08 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1328902266-25308-6-git-send-email-lcapitulino@redhat.com> (Luiz
	Capitulino's message of "Fri, 10 Feb 2012 17:31:05 -0200")
References: <1328902266-25308-1-git-send-email-lcapitulino@redhat.com>
	<1328902266-25308-6-git-send-email-lcapitulino@redhat.com>
Date: Wed, 15 Feb 2012 14:15:05 +0100
Message-ID: <87mx8kgrvq.fsf@elfo.elfo>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything
	to do with monitors
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

Luiz Capitulino <lcapitulino@redhat.com> wrote:
> The Monitor object is passed back and forth within the migration/savevm
> code so that it can print errors and progress to the user.
>
> However, that approach assumes a HMP monitor, being completely invalid
> in QMP.
>
> This commit drops almost every single usage of the Monitor object, all
> monitor_printf() calls have been converted into DPRINTF() ones.
>
> There are a few remaining Monitor objects, those are going to be dropped
> by the next commit.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

Basically only block-migration.c uses the monitor at all (rest of code
only pass around for block migration).  Block migration don't work vey
well (to put it midly) at the moment.

I agree with removing the parameter, and also the info if that is
required.

Later, Juan.