qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Corey Minyard <corey@minyard.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 3/3] cleanup: Drop pointless label at end of function
Date: Wed, 19 Mar 2025 20:21:20 +0100	[thread overview]
Message-ID: <87o6xwkerz.fsf@pond.sub.org> (raw)
In-Reply-To: <CAB9gMfrxe7NWk_1GkudEeWby-ZHaH1xTWD5n7WfK7iz4qKsL6g@mail.gmail.com> (Corey Minyard's message of "Wed, 19 Mar 2025 13:59:09 -0500")

Corey Minyard <corey@minyard.net> writes:

> Is this official coding style?  I'm not a big fan of having return
> statements in the middle of functions, I generally only put them at
> the beginning or the end.

There's nothing in docs/devel/style.rst.

I count more than 42,000 return statements with indentation > 4.  These
are either within some block, or incorrectly indented.  I'd bet my own
money that it's the former for pretty much all of them.

I count less than 130 labels right before a return statement at end of a
function.

Based on that, I'd say return in the middle of function is
overwhelmingly common in our code.



  reply	other threads:[~2025-03-19 19:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-19 15:21 [PATCH 0/3] Cleanups around returns Markus Armbruster
2025-03-19 15:21 ` [PATCH 1/3] cleanup: Re-run return_directly.cocci Markus Armbruster
2025-03-19 15:21 ` [PATCH 2/3] cleanup: Drop pointless return at end of function Markus Armbruster
2025-03-19 15:21 ` [PATCH 3/3] cleanup: Drop pointless label " Markus Armbruster
2025-03-19 18:59   ` Corey Minyard
2025-03-19 19:21     ` Markus Armbruster [this message]
2025-03-19 19:42       ` Corey Minyard
2025-03-19 19:49         ` Markus Armbruster
2025-03-19 20:51           ` Corey Minyard
2025-03-19 20:52             ` Corey Minyard
2025-03-20  9:28         ` Daniel P. Berrangé
2025-03-19 20:07       ` Alex Bennée
2025-03-19 16:00 ` [PATCH 0/3] Cleanups around returns Richard Henderson
2025-03-19 16:21 ` Peter Maydell
2025-03-19 19:09   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o6xwkerz.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=corey@minyard.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).