From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 042A3C021A4 for ; Mon, 24 Feb 2025 12:37:48 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tmXhl-00008K-Ri; Mon, 24 Feb 2025 07:37:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tmXhc-00007F-H1 for qemu-devel@nongnu.org; Mon, 24 Feb 2025 07:36:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tmXhY-00087F-8c for qemu-devel@nongnu.org; Mon, 24 Feb 2025 07:36:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740400606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/lG84J+oLpY6HX1cwf+8/7W23hj2BgCbaP4GSAwyzPM=; b=BBt7k/hlyrVJp889jwl6wkfQcMyRd6mBmilLKcjjc4QW3zsAll3qoLeZJkswI++bV4P7BF HXzj/sgnrgAD5LvD2/odSYXsZiQ3k0Lb0eNDdLJzz7TLBXpwpng6TPcKLkycOxLVfYjnue WxNVQoJYow1k0ypRLCew6mwCRyK6E40= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-YHDbtp6mMRi-LXv184qcdA-1; Mon, 24 Feb 2025 07:36:44 -0500 X-MC-Unique: YHDbtp6mMRi-LXv184qcdA-1 X-Mimecast-MFC-AGG-ID: YHDbtp6mMRi-LXv184qcdA_1740400603 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4A8EE1801A1B; Mon, 24 Feb 2025 12:36:42 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.9]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A74E11956094; Mon, 24 Feb 2025 12:36:41 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 0796621E675F; Mon, 24 Feb 2025 13:36:39 +0100 (CET) From: Markus Armbruster To: John Snow Cc: qemu-devel@nongnu.org, Michael Roth , Thomas Huth , Peter Maydell , Alex =?utf-8?Q?Benn=C3=A9e?= , Cleber Rosa , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Daniel P. =?utf-8?Q?Berrang=C3=A9?= Subject: Re: [PATCH 02/10] python: add qapi static analysis tests In-Reply-To: <20250224033741.222749-3-jsnow@redhat.com> (John Snow's message of "Sun, 23 Feb 2025 22:37:33 -0500") References: <20250224033741.222749-1-jsnow@redhat.com> <20250224033741.222749-3-jsnow@redhat.com> Date: Mon, 24 Feb 2025 13:36:39 +0100 Message-ID: <87o6yrfrjc.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org John Snow writes: > Update the python tests to also check qapi. No idea why I didn't do this > before. I guess I was counting on moving it under python/ and then just > forgot after that was NACKed. Oops, this turns out to be really easy. > > flake8, isort and mypy use the tool configuration from the existing > python directory. pylint continues to use the special configuration > located in scripts/qapi/ - that configuration is more permissive. If we > wish to unify the two configurations, that's a separate series and a > discussion for a later date. > > As a result of this patch, one would be able to run any of the following > tests locally from the qemu.git/python directory and have it cover the > scripts/qapi/ module as well. All of the following options run the > python tests, static analysis tests, and linter checks; but with > different combinations of dependencies and interpreters. > > - "make check-minreqs" Run tests specifically under our oldest supported > Python and our oldest supported dependencies. This is the test that > runs on GitLab as "check-python-minreqs". This helps ensure we do not > regress support on older platforms accidentally. > > - "make check-tox" Runs the tests under the newest supported > dependencies, but under each supported version of Python in turn. At > time of writing, this is Python 3.8 to 3.13 inclusive. This test helps > catch bleeding-edge problems before they become problems for developer > workstations. This is the GitLab test "check-python-tox" and is an > optionally run, may-fail test due to the unpredictable nature of new > dependencies being released into the ecosystem that may cause > regressions. > > - "make check-dev" Runs the tests under the newest supported > dependencies using whatever version of Python the user happens to have > installed. This is a quick convenience check that does not map to any > particular GitLab test. > > (Note! check-dev may be busted on Fedora 41 and bleeding edge versions It is for me. > of setuptools. That's unrelated to this patch and I'll address it > separately and soon. Thank you for your patience, --mgmt) Which of these tests, if any, run in "make check"? In CI? > Signed-off-by: John Snow