From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C3E9C48297 for ; Mon, 12 Feb 2024 11:25:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZUQg-0000b4-Dh; Mon, 12 Feb 2024 06:24:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZUQe-0000an-N5; Mon, 12 Feb 2024 06:24:52 -0500 Received: from ik1-413-38519.vs.sakura.ne.jp ([153.127.30.23] helo=sakura.ysato.name) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZUQZ-0003wV-Si; Mon, 12 Feb 2024 06:24:52 -0500 Received: from SIOS1075.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id D8F4B1C00F9; Mon, 12 Feb 2024 20:24:40 +0900 (JST) Date: Mon, 12 Feb 2024 20:24:38 +0900 Message-ID: <87o7cmgc21.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Mark Cave-Ayland , Zhao Liu , Paolo Bonzini , qemu-block@nongnu.org, John Snow , qemu-ppc@nongnu.org, Eduardo Habkost , Richard Henderson , Markus Armbruster Subject: Re: [PATCH v3 02/11] hw/rx/rx62n: Reduce inclusion of 'qemu/units.h' In-Reply-To: <20240208181245.96617-3-philmd@linaro.org> References: <20240208181245.96617-1-philmd@linaro.org> <20240208181245.96617-3-philmd@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Received-SPF: softfail client-ip=153.127.30.23; envelope-from=ysato@users.sourceforge.jp; helo=sakura.ysato.name X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, KHOP_HELO_FCRDNS=0.252, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, 09 Feb 2024 03:12:35 +0900, Philippe Mathieu-Daud=E9 wrote: >=20 > "qemu/units.h" is not used in the "hw/rx/rx62n.h" > header, include it in the source where it is. >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 > --- > include/hw/rx/rx62n.h | 1 - > hw/rx/rx-gdbsim.c | 1 + > hw/rx/rx62n.c | 1 + > 3 files changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/include/hw/rx/rx62n.h b/include/hw/rx/rx62n.h > index 73ceeb58e5..bcda583ab3 100644 > --- a/include/hw/rx/rx62n.h > +++ b/include/hw/rx/rx62n.h > @@ -29,7 +29,6 @@ > #include "hw/timer/renesas_tmr.h" > #include "hw/timer/renesas_cmt.h" > #include "hw/char/renesas_sci.h" > -#include "qemu/units.h" > #include "qom/object.h" > =20 > #define TYPE_RX62N_MCU "rx62n-mcu" > diff --git a/hw/rx/rx-gdbsim.c b/hw/rx/rx-gdbsim.c > index 47c17026c7..bb4746c556 100644 > --- a/hw/rx/rx-gdbsim.c > +++ b/hw/rx/rx-gdbsim.c > @@ -20,6 +20,7 @@ > #include "qemu/cutils.h" > #include "qemu/error-report.h" > #include "qemu/guest-random.h" > +#include "qemu/units.h" > #include "qapi/error.h" > #include "hw/loader.h" > #include "hw/rx/rx62n.h" > diff --git a/hw/rx/rx62n.c b/hw/rx/rx62n.c > index 4dc44afd9d..d3f61a6837 100644 > --- a/hw/rx/rx62n.c > +++ b/hw/rx/rx62n.c > @@ -23,6 +23,7 @@ > #include "qemu/osdep.h" > #include "qapi/error.h" > #include "qemu/error-report.h" > +#include "qemu/units.h" > #include "hw/rx/rx62n.h" > #include "hw/loader.h" > #include "hw/sysbus.h" > --=20 > 2.41.0 >=20 Reviewed-by: Yoshinori Sato --=20 Yosinori Sato