qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: "Volker Rümelin" <vr_qemu@t-online.de>
Cc: qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
	"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
	"Eric Farman" <farman@linux.ibm.com>,
	qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
	"Thomas Huth" <thuth@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Fabiano Rosas" <farosas@suse.de>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Corey Minyard" <cminyard@mvista.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Peter Xu" <peterx@redhat.com>, "Corey Minyard" <minyard@acm.org>,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Leonardo Bras" <leobras@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Ilya Leoshkevich" <iii@linux.ibm.com>,
	"Jason Wang" <jasowang@redhat.com>,
	qemu-block@nongnu.org, qemu-s390x@nongnu.org,
	"Cédric Le Goater" <clg@kaod.org>,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Stefan Berger" <stefanb@linux.ibm.com>
Subject: Re: [PATCH v2 11/13] migration: Use vmstate_register_any() for audio
Date: Mon, 23 Oct 2023 18:29:21 +0200	[thread overview]
Message-ID: <87o7gpb8v2.fsf@secure.mitica> (raw)
In-Reply-To: <3217207d-7b75-4354-8923-c637b19700fa@t-online.de> ("Volker Rümelin"'s message of "Sat, 21 Oct 2023 16:55:59 +0200")

Volker Rümelin <vr_qemu@t-online.de> wrote:
> Am 20.10.23 um 11:07 schrieb Juan Quintela:
>> We can have more than one audio card.
>
> Hi Juan,
>
> I wouldn't use the term "audio card" here. In QEMU speak, Audiodev is an
> "audio backend".

Thanks.  Changed that.

> With best regards,
> Volker
>
>>
>> void audio_init_audiodevs(void)
>> {
>>     AudiodevListEntry *e;
>>
>>     QSIMPLEQ_FOREACH(e, &audiodevs, next) {
>>         audio_init(e->dev, &error_fatal);
>>     }
>> }
>>
>> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>>  audio/audio.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/audio/audio.c b/audio/audio.c
>> index e9815d6812..f91e05b72c 100644
>> --- a/audio/audio.c
>> +++ b/audio/audio.c
>> @@ -1781,7 +1781,7 @@ static AudioState *audio_init(Audiodev *dev, Error **errp)
>>  
>>      QTAILQ_INSERT_TAIL(&audio_states, s, list);
>>      QLIST_INIT (&s->card_head);
>> -    vmstate_register (NULL, 0, &vmstate_audio, s);
>> +    vmstate_register_any(NULL, &vmstate_audio, s);
>>      return s;
>>  
>>  out:



  reply	other threads:[~2023-10-23 16:29 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20  9:07 [PATCH v2 00/13] migration: Check for duplicates on vmstate_register() Juan Quintela
2023-10-20  9:07 ` [PATCH v2 01/13] migration: Create vmstate_register_any() Juan Quintela
2023-10-20  9:07 ` [PATCH v2 02/13] migration: Use vmstate_register_any() Juan Quintela
2023-10-20  9:07 ` [PATCH v2 03/13] migration: Use vmstate_register_any() for isa-ide Juan Quintela
2023-10-20 14:12   ` Thomas Huth
2023-10-20 19:42     ` Juan Quintela
2023-10-23  6:02       ` Thomas Huth
2023-10-24 10:55         ` Juan Quintela
2023-10-20  9:07 ` [PATCH v2 04/13] migration: Use vmstate_register_any() for ipmi-bt* Juan Quintela
2023-10-20 13:11   ` Thomas Huth
2023-10-20 14:58   ` Thomas Huth
2023-10-20  9:07 ` [PATCH v2 05/13] migration: Use VMSTATE_INSTANCE_ID_ANY for slirp Juan Quintela
2023-10-20  9:07 ` [PATCH v2 06/13] migration: Use VMSTATE_INSTANCE_ID_ANY for s390 devices Juan Quintela
2023-10-20  9:26   ` Christian Borntraeger
2023-10-20  9:54     ` Juan Quintela
2023-10-20 10:04       ` Thomas Huth
2023-10-20 15:08   ` Thomas Huth
2023-10-20  9:07 ` [PATCH v2 07/13] migration: Hack to maintain backwards compatibility for ppc Juan Quintela
2023-10-20 10:19   ` Nicholas Piggin
2023-10-20  9:07 ` [PATCH v2 08/13] migration: vmstate_register() check that instance_id is valid Juan Quintela
2023-10-20  9:07 ` [PATCH v2 09/13] migration: Check in savevm_state_handler_insert for dups Juan Quintela
2023-10-20  9:07 ` [PATCH v2 10/13] migration: Improve example and documentation of vmstate_register() Juan Quintela
2023-10-20 12:22   ` Stefan Berger
2023-10-20  9:07 ` [PATCH v2 11/13] migration: Use vmstate_register_any() for audio Juan Quintela
2023-10-21 14:55   ` Volker Rümelin
2023-10-23 16:29     ` Juan Quintela [this message]
2023-10-20  9:07 ` [PATCH v2 12/13] migration: Use vmstate_register_any() for eeprom93xx Juan Quintela
2023-10-20  9:07 ` [PATCH v2 13/13] migration: Use vmstate_register_any() for vmware_vga Juan Quintela
2023-10-20 14:22   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7gpb8v2.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=clg@kaod.org \
    --cc=cminyard@mvista.com \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=farosas@suse.de \
    --cc=harshpb@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=jasowang@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=leobras@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=minyard@acm.org \
    --cc=mst@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=pasic@linux.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=stefanb@linux.ibm.com \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    --cc=vr_qemu@t-online.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).