From: Juan Quintela <quintela@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Peter Xu <peterx@redhat.com>,
Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH 2/2] meson: Add static glib dependency for initrd-stress.img
Date: Fri, 26 May 2023 12:32:44 +0200 [thread overview]
Message-ID: <87o7m71iyb.fsf@secure.mitica> (raw)
In-Reply-To: <20230525212044.30222-3-farosas@suse.de> (Fabiano Rosas's message of "Thu, 25 May 2023 18:20:44 -0300")
Fabiano Rosas <farosas@suse.de> wrote:
> We recently moved glib detection code to meson but the static libs
> were left out. Add a specific dependency for stress.c which is linked
> statically.
>
> $ make V=1 tests/migration/initrd-stress.img
>
> before:
> cc -m64 -mcx16 -o tests/migration/stress ... -static -Wl,--start-group
> /usr/lib64/libglib-2.0.so -Wl,--end-group
> ...
> bin/ld: attempted static link of dynamic object `/usr/lib64/libglib-2.0.so'
>
> after:
> cc -m64 -mcx16 -o tests/migration/stress ... -static -pthread
> -Wl,--start-group -lm /usr/lib64/libpcre.a -lglib-2.0 -Wl,--end-group
>
> Fixes: fc9a809e0d ("build: move glib detection and workarounds to meson")
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Tested-by: Juan Quintela <quintela@redhat.com>
queued.
next prev parent reply other threads:[~2023-05-26 10:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 21:20 [PATCH 0/2] meson: Fix initrd-stress.img build Fabiano Rosas
2023-05-25 21:20 ` [PATCH 1/2] meson: Remove leftover comment Fabiano Rosas
2023-05-25 21:20 ` [PATCH 2/2] meson: Add static glib dependency for initrd-stress.img Fabiano Rosas
2023-05-26 10:32 ` Juan Quintela [this message]
2023-05-26 10:35 ` Daniel P. Berrangé
2023-05-26 13:09 ` Fabiano Rosas
2023-05-26 8:19 ` [PATCH 0/2] meson: Fix initrd-stress.img build Paolo Bonzini
2023-05-26 11:36 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7m71iyb.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=farosas@suse.de \
--cc=leobras@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).