From: Juan Quintela <quintela@redhat.com>
To: Leonardo Bras <leobras@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Peter Xu <peterx@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v1 2/4] migration/multifd: Remove unnecessary assignment on multifd_load_cleanup()
Date: Fri, 10 Feb 2023 13:48:12 +0100 [thread overview]
Message-ID: <87o7q1hek3.fsf@secure.mitica> (raw)
In-Reply-To: <20230210063630.532185-2-leobras@redhat.com> (Leonardo Bras's message of "Fri, 10 Feb 2023 03:36:29 -0300")
Leonardo Bras <leobras@redhat.com> wrote:
> Before assigning "p->quit = true" for every multifd channel,
> multifd_load_cleanup() will call multifd_recv_terminate_threads() which
> already does the same assignment, while protected by a mutex.
>
> So there is no point doing the same assignment again.
>
> Signed-off-by: Leonardo Bras <leobras@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
good catch
next prev parent reply other threads:[~2023-02-10 12:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 6:36 [PATCH v1 1/4] migration/multifd: Change multifd_load_cleanup() signature and usage Leonardo Bras
2023-02-10 6:36 ` [PATCH v1 2/4] migration/multifd: Remove unnecessary assignment on multifd_load_cleanup() Leonardo Bras
2023-02-10 12:48 ` Juan Quintela [this message]
2023-02-10 17:19 ` Peter Xu
2023-02-10 6:36 ` [PATCH v1 3/4] migration/multifd: Join all multifd threads in order to avoid leaks Leonardo Bras
2023-02-10 12:49 ` Juan Quintela
2023-02-10 17:21 ` Peter Xu
2023-02-10 6:36 ` [PATCH v1 4/4] migration/multifd: Move load_cleanup inside incoming_state_destroy Leonardo Bras
2023-02-10 6:40 ` Leonardo Brás
2023-02-10 12:51 ` Juan Quintela
2023-02-10 12:46 ` [PATCH v1 1/4] migration/multifd: Change multifd_load_cleanup() signature and usage Juan Quintela
2023-02-10 17:18 ` Peter Xu
-- strict thread matches above, loose matches on Subject: below --
2023-02-10 6:31 Leonardo Bras
2023-02-10 6:31 ` [PATCH v1 2/4] migration/multifd: Remove unnecessary assignment on multifd_load_cleanup() Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7q1hek3.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).