qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: "Jason Wang" <jasowang@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	qemu-discuss@nongnu.org
Subject: Re: If your networking is failing after updating to the latest git version of QEMU...
Date: Mon, 03 Oct 2022 09:58:03 +0100	[thread overview]
Message-ID: <87o7utnuzp.fsf@linaro.org> (raw)
In-Reply-To: <a25c238b-dabd-bf20-9aee-7cda4e422536@redhat.com>


Thomas Huth <thuth@redhat.com> writes:

> On 29/09/2022 04.32, Jason Wang wrote:
>> On Thu, Sep 29, 2022 at 1:06 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>>
>>> On 28/9/22 10:27, Thomas Huth wrote:
>>>>
>>>> ... it might have happened due to the removal of the "slirp" submodule
>>>> from the git repository. For example if you see an error message like this:
>>>>
>>>>    Parameter 'type' expects a netdev backend type
>>>>
>>>> this likely means that the "user" mode backend type is not available in
>>>> your binary anymore. To fix it, simply install "libslirp-devel" (or
>>>> libslirp-dev or however it is called) from your OS distribution and
>>>> recompile.
>>>
>>> Thanks for the hint Thomas. I'm afraid many developers will miss your
>>> email.
>>>
>>> Jason, Marc-André, could we improve the buildsys check or display
>>> a more helpful information from the code instead?
>> It looks to me we need to improve the build.
>
> I'm not sure there is anything to improve in the build system -
> configure/meson.build are just doing what they should: Pick the
> default value for "slirp" if the user did not explicitly specify
> "--enable-slirp".

Shouldn't it be the other way round and fail to configure unless the
user explicitly calls --disable-slirp?

>
> But the error message is not very helpful. It should rather say
> something like (partly suggested by Daniel in IRC yesterday already):
>
>  Type 'user' is not a supported netdev backend by this QEMU build.
>  Please check the spelling or whether it has been enabled at
> compilation time.
>
> ... or something like this.
>
> Someone interested to write a patch?
>
>  Thomas


-- 
Alex Bennée


  reply	other threads:[~2022-10-03  9:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28  8:27 If your networking is failing after updating to the latest git version of QEMU Thomas Huth
2022-09-28 17:06 ` Philippe Mathieu-Daudé via
2022-09-29  2:32   ` Jason Wang
2022-09-29  6:34     ` Thomas Huth
2022-10-03  8:58       ` Alex Bennée [this message]
2022-10-03  9:26         ` Peter Maydell
2022-10-03 10:22           ` Alex Bennée
2022-10-03 10:36             ` Peter Maydell
2022-10-03 11:03               ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7utnuzp.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=jasowang@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-discuss@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).