From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v3 24/39] include/exec/log: Do not reference QemuLogFile directly
Date: Tue, 19 Apr 2022 11:14:30 +0100 [thread overview]
Message-ID: <87o80xxtv5.fsf@linaro.org> (raw)
In-Reply-To: <20220417183019.755276-25-richard.henderson@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> Use qemu_log_trylock/unlock instead of the raw rcu_read.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
next prev parent reply other threads:[~2022-04-19 10:20 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 18:29 [PATCH v3 00/39] Logging cleanup and per-thread logfiles Richard Henderson
2022-04-17 18:29 ` [PATCH v3 01/39] util/log: Drop manual log buffering Richard Henderson
2022-04-17 18:29 ` [PATCH v3 02/39] target/hexagon: Remove qemu_set_log in hexagon_translate_init Richard Henderson
2022-04-17 18:29 ` [PATCH v3 03/39] util/log: Return bool from qemu_set_log_filename Richard Henderson
2022-04-17 18:29 ` [PATCH v3 04/39] util/log: Pass Error pointer to qemu_set_log Richard Henderson
2022-04-17 18:29 ` [PATCH v3 05/39] os-posix: Use qemu_log_enabled Richard Henderson
2022-04-17 18:29 ` [PATCH v3 06/39] util/log: Move qemu_log_lock, qemu_log_unlock out of line Richard Henderson
2022-04-17 18:29 ` [PATCH v3 07/39] util/log: Rename qemu_log_lock to qemu_log_trylock Richard Henderson
2022-04-17 18:29 ` [PATCH v3 08/39] hw/xen: Split out xen_pv_output_msg Richard Henderson
2022-04-17 18:29 ` [PATCH v3 09/39] *: Use fprintf between qemu_log_trylock/unlock Richard Henderson
2022-04-17 18:29 ` [PATCH v3 10/39] util/log: Remove qemu_log_vprintf Richard Henderson
2022-04-17 18:29 ` [PATCH v3 11/39] tcg: Pass the locked filepointer to tcg_dump_ops Richard Henderson
2022-04-17 18:29 ` [PATCH v3 12/39] exec/translator: Pass the locked filepointer to disas_log hook Richard Henderson
2022-04-17 18:29 ` [PATCH v3 13/39] exec/log: Remove log_disas and log_target_disas Richard Henderson
2022-04-17 18:29 ` [PATCH v3 14/39] accel/tcg: Use cpu_dump_state between qemu_log_trylock/unlock Richard Henderson
2022-04-17 18:29 ` [PATCH v3 15/39] target/nios2: Remove log_cpu_state from reset Richard Henderson
2022-04-17 18:29 ` [PATCH v3 16/39] util/log: Use qemu_log_trylock/unlock in qemu_log Richard Henderson
2022-04-17 18:29 ` [PATCH v3 17/39] util/log: Drop return value from qemu_log Richard Henderson
2022-04-17 18:29 ` [PATCH v3 18/39] util/log: Mark qemu_log_trylock as G_GNUC_WARN_UNUSED_RESULT Richard Henderson
2022-04-17 18:29 ` [PATCH v3 19/39] util/log: Remove qemu_log_flush Richard Henderson
2022-04-17 18:30 ` [PATCH v3 20/39] util/log: Drop call to setvbuf Richard Henderson
2022-04-17 18:30 ` [PATCH v3 21/39] bsd-user: Expand log_page_dump inline Richard Henderson
2022-04-17 18:30 ` [PATCH v3 22/39] linux-user: " Richard Henderson
2022-04-17 18:30 ` [PATCH v3 23/39] tests/unit: Do not reference QemuLogFile directly Richard Henderson
2022-04-17 18:30 ` [PATCH v3 24/39] include/exec/log: " Richard Henderson
2022-04-19 10:14 ` Alex Bennée [this message]
2022-04-17 18:30 ` [PATCH v3 25/39] include/qemu/log: Move entire implementation out-of-line Richard Henderson
2022-04-17 18:30 ` [PATCH v3 26/39] sysemu/os-win32: Test for and use _lock_file/_unlock_file Richard Henderson
2022-04-17 18:30 ` [PATCH v3 27/39] util/log: Introduce qemu_set_log_filename_flags Richard Henderson
2022-04-17 18:30 ` [PATCH v3 28/39] bsd-user: Use qemu_set_log_filename_flags Richard Henderson
2022-04-17 18:30 ` [PATCH v3 29/39] linux-user: " Richard Henderson
2022-04-17 18:30 ` [PATCH v3 30/39] softmmu: " Richard Henderson
2022-04-17 18:30 ` [PATCH v3 31/39] util/log: Remove qemu_log_close Richard Henderson
2022-04-17 18:30 ` [PATCH v3 32/39] util/log: Rename logfilename to global_filename Richard Henderson
2022-04-17 18:30 ` [PATCH v3 33/39] util/log: Rename qemu_logfile to global_file Richard Henderson
2022-04-17 18:30 ` [PATCH v3 34/39] util/log: Rename qemu_logfile_mutex to global_mutex Richard Henderson
2022-04-17 18:30 ` [PATCH v3 35/39] util/log: Hoist the eval of is_daemonized in qemu_set_log_internal Richard Henderson
2022-04-17 18:30 ` [PATCH v3 36/39] util/log: Combine two logfile closes Richard Henderson
2022-04-17 18:30 ` [PATCH v3 37/39] util/log: Rename QemuLogFile to RCUCloseFILE Richard Henderson
2022-04-17 18:30 ` [PATCH v3 38/39] util/log: Limit RCUCloseFILE to file closing Richard Henderson
2022-04-17 18:30 ` [PATCH v3 39/39] util/log: Support per-thread log files Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o80xxtv5.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).