qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Tomoaki Kawada <i@yvt.jp>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] target/rx: set PSW.I when executing wait instruction
Date: Mon, 18 Apr 2022 22:17:46 +0900	[thread overview]
Message-ID: <87o80ymsxx.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20220417045937.2128699-1-i@yvt.jp>

On Sun, 17 Apr 2022 13:59:38 +0900,
Tomoaki Kawada wrote:
> 
> This patch fixes the implementation of the wait instruction to
> implicitly update PSW.I as required by the ISA specification.
> 
> Signed-off-by: Tomoaki Kawada <i@yvt.jp>
> ---
>  target/rx/op_helper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c
> index 11f952d340..81645adde3 100644
> --- a/target/rx/op_helper.c
> +++ b/target/rx/op_helper.c
> @@ -448,6 +448,7 @@ void QEMU_NORETURN helper_wait(CPURXState *env)
>  
>      cs->halted = 1;
>      env->in_sleep = 1;
> +    env->psw_i = 1;
>      raise_exception(env, EXCP_HLT, 0);
>  }
>  
> -- 
> 2.35.1
> 

Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>

-- 
Yosinori Sato


  parent reply	other threads:[~2022-04-18 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-17  4:59 [PATCH] target/rx: set PSW.I when executing wait instruction Tomoaki Kawada
2022-04-17 16:02 ` Richard Henderson
2022-04-18 13:17 ` Yoshinori Sato [this message]
2022-04-21 17:08 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o80ymsxx.wl-ysato@users.sourceforge.jp \
    --to=ysato@users.sourceforge.jp \
    --cc=i@yvt.jp \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).