From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4B60C433F5 for ; Mon, 18 Apr 2022 13:20:05 +0000 (UTC) Received: from localhost ([::1]:44648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngRIS-00026D-E6 for qemu-devel@archiver.kernel.org; Mon, 18 Apr 2022 09:20:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngRGP-0001At-IQ for qemu-devel@nongnu.org; Mon, 18 Apr 2022 09:17:57 -0400 Received: from mail12.asahi-net.or.jp ([202.224.55.52]:44524) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngRGK-00020X-In for qemu-devel@nongnu.org; Mon, 18 Apr 2022 09:17:54 -0400 Received: from sakura.ysato.name (ik1-413-38519.vs.sakura.ne.jp [153.127.30.23]) (Authenticated sender: PQ4Y-STU) by mail12.asahi-net.or.jp (Postfix) with ESMTPA id 0BE312F905; Mon, 18 Apr 2022 22:17:47 +0900 (JST) Received: from SIOS1075.ysato.ml (ZM005235.ppp.dion.ne.jp [222.8.5.235]) by sakura.ysato.name (Postfix) with ESMTPSA id 3F23A1C0173; Mon, 18 Apr 2022 22:17:47 +0900 (JST) Date: Mon, 18 Apr 2022 22:17:46 +0900 Message-ID: <87o80ymsxx.wl-ysato@users.sourceforge.jp> From: Yoshinori Sato To: Tomoaki Kawada Subject: Re: [PATCH] target/rx: set PSW.I when executing wait instruction In-Reply-To: <20220417045937.2128699-1-i@yvt.jp> References: <20220417045937.2128699-1-i@yvt.jp> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Received-SPF: softfail client-ip=202.224.55.52; envelope-from=ysato@users.sourceforge.jp; helo=mail12.asahi-net.or.jp X-Spam_score_int: 15 X-Spam_score: 1.5 X-Spam_bar: + X-Spam_report: (1.5 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_PSBL=2.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sun, 17 Apr 2022 13:59:38 +0900, Tomoaki Kawada wrote: > > This patch fixes the implementation of the wait instruction to > implicitly update PSW.I as required by the ISA specification. > > Signed-off-by: Tomoaki Kawada > --- > target/rx/op_helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c > index 11f952d340..81645adde3 100644 > --- a/target/rx/op_helper.c > +++ b/target/rx/op_helper.c > @@ -448,6 +448,7 @@ void QEMU_NORETURN helper_wait(CPURXState *env) > > cs->halted = 1; > env->in_sleep = 1; > + env->psw_i = 1; > raise_exception(env, EXCP_HLT, 0); > } > > -- > 2.35.1 > Reviewed-by: Yoshinori Sato -- Yosinori Sato