From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6696C432C0 for ; Mon, 18 Nov 2019 11:49:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E9F120730 for ; Mon, 18 Nov 2019 11:49:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kN27ncgc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E9F120730 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWfX8-0003en-NM for qemu-devel@archiver.kernel.org; Mon, 18 Nov 2019 06:49:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52957) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWfW3-0003Cb-1E for qemu-devel@nongnu.org; Mon, 18 Nov 2019 06:48:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWfW0-0003zC-LU for qemu-devel@nongnu.org; Mon, 18 Nov 2019 06:48:22 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:39663) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWfVz-0003y8-GO for qemu-devel@nongnu.org; Mon, 18 Nov 2019 06:48:20 -0500 Received: by mail-wm1-x341.google.com with SMTP id t26so18453707wmi.4 for ; Mon, 18 Nov 2019 03:48:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=SGO3fKTybnsKIbpCaSCw/GRmpWTdiDYOlCQeDqcyN64=; b=kN27ncgcuqKtBDSkEzoU/UPeZE+0wWZbxGZXR0GprZG1vNpw+w/yXL8MYBQXd1CwNd ccEqp8oq+fdrWOjKVhIrROUq/BHiXAYn9Z/swGgpw4C9utzaUV6KXUlMRiKFXAlOUBNm 1POXRuuEdsIzYN8Etum1F43XKhFjBFhP0V3QPl7YY7F3b10ETIc9A/X57B6MFbGilnNF 0746Fp/jXbHO67H7VDdESNQ5RzJD3Hbs3H+IoIMmpbqPySmg/TI9ueJ4wwf/9BnANPOf RYGtGiVVuz2q2Dh8FJP3wHZ66I0dd9zpRQtV6iQrjk6/nMAmCtqn2NGCgbCpR7mVvp+j 9LTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=SGO3fKTybnsKIbpCaSCw/GRmpWTdiDYOlCQeDqcyN64=; b=kzZmfYgiZ/zvTas+SvRszdZ5zeSU+yolrF77oQOEUO/+B8IGVRakMM3V9p2bcr8VWw DeUKZLmk9mufAvt9R7mARnN8HICKR3AmWtYE0zvzRoYSmVu/RN/G2/3Wb+03hWYmiSwF yK0TcVhTgx5MeVIVnDA6TtgKwNGFxgaTrzcN8AkhJwLhkZw0RzgAnXLziEi5C+8XhE81 /GnqDEyLbKfvrP0aacTtEb88B5UgaziM/q0vBflN5CvkwB7MRrvnFVHEJPoyznS4qNCt Ust0SXyH+iYGrw7WgW92QYY2cx4KbbxqTCea6ADDbsD66oGYgPoA6Yb14sTHB40V9FHh mD7A== X-Gm-Message-State: APjAAAX2ALqrALrGcbZUOOgLxeIuiKxiVHKnKl6VEdjp5Twm/tgJ1x6h BcdiFTJ0Ny4iYAecbpBn3r7vIDwxu0o= X-Google-Smtp-Source: APXvYqyJOyUhQKF/pL0zuRzdejSGCQlil+wNoDLUSZRIIWuIsfS5AztWHQlwP9FFfibXCzvT66uIFA== X-Received: by 2002:a05:600c:489:: with SMTP id d9mr16554762wme.20.1574077697059; Mon, 18 Nov 2019 03:48:17 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id k4sm20973030wmk.26.2019.11.18.03.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 03:48:15 -0800 (PST) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 1E0031FF87; Mon, 18 Nov 2019 11:48:15 +0000 (GMT) References: <1574032465-12186-1-git-send-email-tsimpson@quicinc.com> User-agent: mu4e 1.3.5; emacs 27.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: Taylor Simpson Subject: Re: [PATCH] Modify tests to work with clang In-reply-to: <1574032465-12186-1-git-send-email-tsimpson@quicinc.com> Date: Mon, 18 Nov 2019 11:48:14 +0000 Message-ID: <87o8x9h0ch.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Taylor Simpson writes: > Signed-off-by: Taylor Simpson Queued to 4.2/for-rc2, thanks. > --- > tests/tcg/multiarch/float_helpers.c | 2 -- > tests/tcg/multiarch/linux-test.c | 6 +++++- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/tests/tcg/multiarch/float_helpers.c b/tests/tcg/multiarch/fl= oat_helpers.c > index 8ee7903..bc530e5 100644 > --- a/tests/tcg/multiarch/float_helpers.c > +++ b/tests/tcg/multiarch/float_helpers.c > @@ -79,11 +79,9 @@ char *fmt_16(uint16_t num) > > #ifndef SNANF > /* Signaling NaN macros, if supported. */ > -# if __GNUC_PREREQ(3, 3) > # define SNANF (__builtin_nansf ("")) > # define SNAN (__builtin_nans ("")) > # define SNANL (__builtin_nansl ("")) > -# endif > #endif > > static float f32_numbers[] =3D { > diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux= -test.c > index 673d7c8..8a7c15c 100644 > --- a/tests/tcg/multiarch/linux-test.c > +++ b/tests/tcg/multiarch/linux-test.c > @@ -485,7 +485,11 @@ static void test_signal(void) > act.sa_flags =3D SA_SIGINFO; > chk_error(sigaction(SIGSEGV, &act, NULL)); > if (setjmp(jmp_env) =3D=3D 0) { > - *(uint8_t *)0 =3D 0; > + /* > + * clang requires volatile or it will turn this into a > + * call to abort() instead of forcing a SIGSEGV. > + */ > + *(volatile uint8_t *)0 =3D 0; > } > > act.sa_handler =3D SIG_DFL; -- Alex Benn=C3=A9e