From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKo90-0003is-Rq for qemu-devel@nongnu.org; Thu, 08 Nov 2018 12:31:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKo8x-0002cz-MJ for qemu-devel@nongnu.org; Thu, 08 Nov 2018 12:31:00 -0500 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:44366) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKo8x-0002As-AB for qemu-devel@nongnu.org; Thu, 08 Nov 2018 12:30:59 -0500 Received: by mail-wr1-x443.google.com with SMTP id j17-v6so17007704wrq.11 for ; Thu, 08 Nov 2018 09:30:40 -0800 (PST) References: <20181108163329.19940-1-alex.bennee@linaro.org> <20181108163329.19940-2-alex.bennee@linaro.org> <3027e46a-42b2-4c5c-eaec-ce9caa64ecc0@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <3027e46a-42b2-4c5c-eaec-ce9caa64ecc0@linaro.org> Date: Thu, 08 Nov 2018 17:30:37 +0000 Message-ID: <87o9az5veq.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/6] target/arm64: properly handle DBGVR RESS bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, qemu-arm@nongnu.org Richard Henderson writes: > On 11/8/18 5:33 PM, Alex Benn=C3=A9e wrote: >> - .bvr =3D addr >> + .bvr =3D sextract64(addr, 52, 53) > > I think you meant sextract64(addr, 0, 53). > What you wrote *should* have asserted, since 52+53 > 64. Dam, I did fix that. I must have failed to propagate the fix from where I was hacking :-/ > > > r~ -- Alex Benn=C3=A9e