From: Markus Armbruster <armbru@redhat.com>
To: Scott Feldman <sfeldma@gmail.com>, Jiri Pirko <jiri@resnulli.us>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: [Qemu-devel] QAPI design mistake: RockerPort member @speed shoud bi
Date: Fri, 04 Aug 2017 17:03:11 +0200 [thread overview]
Message-ID: <87o9rvbck0.fsf@dusky.pond.sub.org> (raw)
RockerPort member @speed is documented to be "in Mbps" (presumably
Megabits/second). It uses QAPI type 'uint32'.
This is inappropriate for QAPI/QMP. It should have been made plain
bits/second (no multiple), and maybe 'uint64'. As far as I can tell,
the QAPI part didn't get review from QAPI experts. Probably because it
wasn't cc'ed to them.
Too late to fix now, but let's not repeat the mistake.
reply other threads:[~2017-08-04 15:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9rvbck0.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jiri@resnulli.us \
--cc=qemu-devel@nongnu.org \
--cc=sfeldma@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).